[
https://issues.apache.org/jira/browse/ARTEMIS-3573?focusedWorklogId=685187&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-685187
]
ASF GitHub Bot logged work on ARTEMIS-3573:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 23/Nov/21 11:11
Start Date: 23/Nov/21 11:11
Worklog Time Spent: 10m
Work Description: gemmellr commented on a change in pull request #3851:
URL: https://github.com/apache/activemq-artemis/pull/3851#discussion_r755020420
##########
File path:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/DefaultSensitiveStringCodec.java
##########
@@ -188,6 +208,16 @@ public String encode(String secret) throws Exception {
BigInteger n = new BigInteger(encoding);
return n.toString(16);
}
+
+ @Override
+ public boolean verify(char[] inputValue, String storedValue) {
+ try {
+ return Objects.equals(storedValue,
encode(String.valueOf(inputValue)));
Review comment:
I'm fine with that also, though I think passing it a char[] is perfectly
reasonable given the use case. Just not defining entirely unnecessary Object
args that only muddy the waters given the usage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 685187)
Time Spent: 3h 50m (was: 3h 40m)
> Support PropertiesLoginModule custom password codecs
> ----------------------------------------------------
>
> Key: ARTEMIS-3573
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3573
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Domenico Francesco Bruscino
> Assignee: Domenico Francesco Bruscino
> Priority: Major
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> The `PropertiesLoginModule` login module supports only the
> `DefaultSensitiveStringCodec` codec to verify the user passwords.
> Add a property to set a custom password codec, i.e.
> org.apache.activemq.jaas.properties.password.codec="org.apache.activemq.artemis.tests.integration.security.MD5SensitiveDataCodec"
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
