[
https://issues.apache.org/jira/browse/ARTEMIS-3771?focusedWorklogId=759779&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-759779
]
ASF GitHub Bot logged work on ARTEMIS-3771:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 21/Apr/22 06:31
Start Date: 21/Apr/22 06:31
Worklog Time Spent: 10m
Work Description: AntonRoskvist commented on PR #4023:
URL:
https://github.com/apache/activemq-artemis/pull/4023#issuecomment-1104767472
@clebertsuconic thanks for the feedback
Okay... at this point I'm basically just moving the current "session-level"
destination cache and making it shared, but the way this cache is implemented
now makes collisions happen so often that I'm not really sure it's worth it to
be honest. I'm mostly doing this for a use case I have with a very large number
of queues and chances of a cache-clash is really high already at "just" some
few hundreds of destinations.
If you prefer I change this (and I can do that for sure), do you think it
makes sense to just store all destinations in something like a hashmap instead
that just holds all destinations, or should I revert this particular part of
the change to it's old behavior, i.e Session-level? Either way is fine for me.
Issue Time Tracking
-------------------
Worklog Id: (was: 759779)
Time Spent: 1h 10m (was: 1h)
> Rework destination handling for the OpenWire-protocol
> -----------------------------------------------------
>
> Key: ARTEMIS-3771
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3771
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Anton Roskvist
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Rework destination handling for the OpenWire-protocol
>
> Mainly improves things for brokers with many destinations and for handling
> clients not reusing JMS resources, but should be a nice overall improvement
> for OpenWire.
> Changes are:
> openWireDestinationCache now global, also taking over the role for the
> connection destination cache
> Avoid calling BindingQuery since that method is expensive when dealing with a
> large number of destinations
> openwireDestinationCacheSize no longer has to be a power of 2
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
