[ 
https://issues.apache.org/jira/browse/ARTEMIS-3771?focusedWorklogId=760318&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-760318
 ]

ASF GitHub Bot logged work on ARTEMIS-3771:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 21/Apr/22 18:57
            Start Date: 21/Apr/22 18:57
    Worklog Time Spent: 10m 
      Work Description: clebertsuconic commented on PR #4023:
URL: 
https://github.com/apache/activemq-artemis/pull/4023#issuecomment-1105640765

   so, it seems we were doing two checks for the address/. queue, one was 
useless and not needed,, correct?
   
   
   on that case can you rename the commit to something more accurate to the 
current state?
   
   
   say:
   
   ```
   ARTEMIS-3771 Avoid not needed lookup for address on OpenWire connections
   ```
   
   
   I can of course use some Git-fu and do it myself... but if you do it 
yourself I guess you wouldn't have my trace as a contributor in your commit.
   
   
   Also, if you could rebase (git pull --rebase upstream main) and git push -f?
   
   
   I can then just run my private CI on top of your PR. (I have a parameterized 
build where I pass in GitHub address and branch name).




Issue Time Tracking
-------------------

    Worklog Id:     (was: 760318)
    Time Spent: 2h 10m  (was: 2h)

> Rework destination handling for the OpenWire-protocol
> -----------------------------------------------------
>
>                 Key: ARTEMIS-3771
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-3771
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>            Reporter: Anton Roskvist
>            Priority: Major
>          Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> Rework destination handling for the OpenWire-protocol
>  
> Mainly improves things for brokers with many destinations and for handling 
> clients not reusing JMS resources, but should be a nice overall improvement 
> for OpenWire.
> Changes are:
> openWireDestinationCache now global, also taking over the role for the 
> connection destination cache
> Avoid calling BindingQuery since that method is expensive when dealing with a 
> large number of destinations
> openwireDestinationCacheSize no longer has to be a power of 2



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to