[ https://issues.apache.org/jira/browse/ARTEMIS-4247?focusedWorklogId=858509&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-858509 ]
ASF GitHub Bot logged work on ARTEMIS-4247: ------------------------------------------- Author: ASF GitHub Bot Created on: 21/Apr/23 20:32 Start Date: 21/Apr/23 20:32 Worklog Time Spent: 10m Work Description: clebertsuconic commented on code in PR #4443: URL: https://github.com/apache/activemq-artemis/pull/4443#discussion_r1174142957 ########## artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/mirror/AMQPMirrorControllerSource.java: ########## @@ -357,6 +364,13 @@ private static void setProtocolData(MessageReference ref, String brokerID, long daMap.put(INTERNAL_DESTINATION, ref.getMessage().getAddress()); } } + + if (routingContext != null && routingContext.isMirrorIndividualRoute()) { + ArrayList<String> queues = new ArrayList<>(); + routingContext.forEachDurable(q -> queues.add(String.valueOf(q.getName()))); + daMap.put(TARGET_QUEUES, queues); + } Review Comment: sending it empty wouldn't be wrong. The only scenario where this could happen is if the queue was removed in flight... Test this will be a bit complicated though. Issue Time Tracking ------------------- Worklog Id: (was: 858509) Time Spent: 2h 50m (was: 2h 40m) > Inconsistencies between AMQP Mirror and Artemis Clustering > ---------------------------------------------------------- > > Key: ARTEMIS-4247 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4247 > Project: ActiveMQ Artemis > Issue Type: Bug > Reporter: Clebert Suconic > Priority: Major > Time Spent: 2h 50m > Remaining Estimate: 0h > > - activemq.notifications are being transferred to the target node, unless an > ignore is setup > - topics are being duplicated after redistribution > - topics sends are being duplicated when a 2 node cluster mirrors to another > 2 node cluster, and both nodes are mirrored. -- This message was sent by Atlassian Jira (v8.20.10#820010)