[
https://issues.apache.org/jira/browse/ARTEMIS-4247?focusedWorklogId=858511&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-858511
]
ASF GitHub Bot logged work on ARTEMIS-4247:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 21/Apr/23 20:39
Start Date: 21/Apr/23 20:39
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4443:
URL: https://github.com/apache/activemq-artemis/pull/4443#discussion_r1174147176
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/mirror/AMQPMirrorControllerSource.java:
##########
@@ -357,6 +364,13 @@ private static void setProtocolData(MessageReference ref,
String brokerID, long
daMap.put(INTERNAL_DESTINATION, ref.getMessage().getAddress());
}
}
+
+ if (routingContext != null && routingContext.isMirrorIndividualRoute()) {
+ ArrayList<String> queues = new ArrayList<>();
+ routingContext.forEachDurable(q ->
queues.add(String.valueOf(q.getName())));
+ daMap.put(TARGET_QUEUES, queues);
+ }
Review Comment:
I would need to test on an impossible situation. That is an artificial
operation routing to a local non durable queue.
Clustered routings will always happen after durable queues.
Issue Time Tracking
-------------------
Worklog Id: (was: 858511)
Time Spent: 3h 10m (was: 3h)
> Inconsistencies between AMQP Mirror and Artemis Clustering
> ----------------------------------------------------------
>
> Key: ARTEMIS-4247
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4247
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Clebert Suconic
> Priority: Major
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> - activemq.notifications are being transferred to the target node, unless an
> ignore is setup
> - topics are being duplicated after redistribution
> - topics sends are being duplicated when a 2 node cluster mirrors to another
> 2 node cluster, and both nodes are mirrored.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
