[
https://issues.apache.org/jira/browse/ARTEMIS-4349?focusedWorklogId=869652&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-869652
]
ASF GitHub Bot logged work on ARTEMIS-4349:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 06/Jul/23 19:08
Start Date: 06/Jul/23 19:08
Worklog Time Spent: 10m
Work Description: jbertram commented on PR #4540:
URL:
https://github.com/apache/activemq-artemis/pull/4540#issuecomment-1624181340
Caffeine is essentially the successor to Google's Guava Cache. It's used by
a lot of projects. Spring, for example, started moving [away from Guava to
Caffeine in
2015](https://github.com/spring-projects/spring-framework/issues/18370). I
considered using Caffeine when I first started using Guava Cache on
[ARTEMIS-2886](https://issues.apache.org/jira/browse/ARTEMIS-2886), but I
decided on Guava mainly because we already had a dependency on it. This PR
completely removes Guava from the code-base in lieu of Caffeine which is fine
by me.
My only real concern is essentially the same as Tim's which I put on
[ARTEMIS-4349](https://issues.apache.org/jira/browse/ARTEMIS-4349?focusedCommentId=17740337&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17740337).
Changing Caffeine for the sake of performance doesn't make much sense without
clear data that changing will actually make any meaningful difference. At this
point we don't have that data.
Issue Time Tracking
-------------------
Worklog Id: (was: 869652)
Time Spent: 50m (was: 40m)
> Replace Guava cache with Caffeine
> ---------------------------------
>
> Key: ARTEMIS-4349
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4349
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Affects Versions: 2.29.0
> Reporter: Alexey Markevich
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> based on benchmark https://github.com/ben-manes/caffeine/wiki/Benchmarks
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
