[
https://issues.apache.org/jira/browse/ARTEMIS-4349?focusedWorklogId=869660&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-869660
]
ASF GitHub Bot logged work on ARTEMIS-4349:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 06/Jul/23 20:29
Start Date: 06/Jul/23 20:29
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on PR #4540:
URL:
https://github.com/apache/activemq-artemis/pull/4540#issuecomment-1624271282
I'm running the whole test suite with these changes (on a separate CI).
If caffeine has a bigger community, the jar is smaller, I think we should
bring this right away (if tests are ok of course).
my initial concern was about the community support and CVEs.. but from what
I later gathered this is actually better.
performance wise I think the differences would be impossible to measure. We
currently use some login changes from Security as Justin mentioned... but you
would have to use the cache quite a lot to have any significant result.
I think we should merge this, but not much for the performance reasons.
anyone has anything against that?
Issue Time Tracking
-------------------
Worklog Id: (was: 869660)
Time Spent: 1h 10m (was: 1h)
> Replace Guava cache with Caffeine
> ---------------------------------
>
> Key: ARTEMIS-4349
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4349
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Affects Versions: 2.29.0
> Reporter: Alexey Markevich
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> based on benchmark https://github.com/ben-manes/caffeine/wiki/Benchmarks
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
