[
https://issues.apache.org/jira/browse/ARTEMIS-4552?focusedWorklogId=899777&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-899777
]
ASF GitHub Bot logged work on ARTEMIS-4552:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 16/Jan/24 07:50
Start Date: 16/Jan/24 07:50
Worklog Time Spent: 10m
Work Description: brusdev commented on code in PR #4729:
URL: https://github.com/apache/activemq-artemis/pull/4729#discussion_r1453038703
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/config/routing/ConnectionRouterConfiguration.java:
##########
@@ -26,8 +26,8 @@ public class ConnectionRouterConfiguration implements
Serializable {
private KeyType keyType = KeyType.SOURCE_IP;
private String keyFilter = null;
private String localTargetFilter = null;
- private CacheConfiguration cacheConfiguration = null;
- private PoolConfiguration poolConfiguration = null;
+ private CacheConfiguration cacheConfiguration = new
CacheConfiguration().setEnabled(false);
+ private PoolConfiguration poolConfiguration = new
PoolConfiguration().setEnabled(false);
Review Comment:
I reverted the default value of the `enabled` bit for cache and pool
configurations to true but I keep the xml attribute `enabled` suggested by
@tabish121. The 3 different ways of configuring things seem more consistent:
- xml: the `connection-router` element has no cache or pool enabled by
default but if you create a cache or pool element they are enabled by default
(this is important for backward compatibility)
- programmatically: the `ConnectionRouterConfiguration` class has no cache
or pool enabled by default but if you create a CacheConfiguration or
PoolConfiguration class they are enabled by default (this is important for
backward compatibility)
- broker properties: the `connectionRouters` items have no cache or pool
enabled by default but you can set enabled to true to enable them
Issue Time Tracking
-------------------
Worklog Id: (was: 899777)
Time Spent: 1h 10m (was: 1h)
> Configure all connection-router settings by using broker properties
> -------------------------------------------------------------------
>
> Key: ARTEMIS-4552
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4552
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Domenico Francesco Bruscino
> Assignee: Domenico Francesco Bruscino
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Allow to configure all the connection-router settings by using the broker
> properties. The broker properties for the cache configuration cause a null
> pointer exception:
> {code}
> "connectionRouters.autoShard.cacheConfiguration.persisted=true"
> "connectionRouters.autoShard.cacheConfiguration.timeout=60000"
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
