[ https://issues.apache.org/jira/browse/ARTEMIS-4552?focusedWorklogId=900438&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-900438 ]
ASF GitHub Bot logged work on ARTEMIS-4552: ------------------------------------------- Author: ASF GitHub Bot Created on: 18/Jan/24 14:01 Start Date: 18/Jan/24 14:01 Worklog Time Spent: 10m Work Description: brusdev commented on code in PR #4729: URL: https://github.com/apache/activemq-artemis/pull/4729#discussion_r1457483882 ########## artemis-server/src/main/java/org/apache/activemq/artemis/core/config/routing/ConnectionRouterConfiguration.java: ########## @@ -26,8 +26,8 @@ public class ConnectionRouterConfiguration implements Serializable { private KeyType keyType = KeyType.SOURCE_IP; private String keyFilter = null; private String localTargetFilter = null; - private CacheConfiguration cacheConfiguration = null; - private PoolConfiguration poolConfiguration = null; + private CacheConfiguration cacheConfiguration = new CacheConfiguration().setEnabled(false); + private PoolConfiguration poolConfiguration = new PoolConfiguration().setEnabled(false); Review Comment: I completely removed the `enabled` attribute. Issue Time Tracking ------------------- Worklog Id: (was: 900438) Time Spent: 1h 40m (was: 1.5h) > Configure all connection-router settings by using broker properties > ------------------------------------------------------------------- > > Key: ARTEMIS-4552 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4552 > Project: ActiveMQ Artemis > Issue Type: Improvement > Reporter: Domenico Francesco Bruscino > Assignee: Domenico Francesco Bruscino > Priority: Major > Time Spent: 1h 40m > Remaining Estimate: 0h > > Allow to configure all the connection-router settings by using the broker > properties. The broker properties for the cache configuration cause a null > pointer exception: > {code} > "connectionRouters.autoShard.cacheConfiguration.persisted=true" > "connectionRouters.autoShard.cacheConfiguration.timeout=60000" > {code} -- This message was sent by Atlassian Jira (v8.20.10#820010)