[ https://issues.apache.org/jira/browse/ARTEMIS-4668?focusedWorklogId=908584&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-908584 ]
ASF GitHub Bot logged work on ARTEMIS-4668: ------------------------------------------- Author: ASF GitHub Bot Created on: 06/Mar/24 15:25 Start Date: 06/Mar/24 15:25 Worklog Time Spent: 10m Work Description: clebertsuconic commented on code in PR #4840: URL: https://github.com/apache/activemq-artemis/pull/4840#discussion_r1514683343 ########## artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/AMQPLargeMessageWriter.java: ########## @@ -81,33 +84,55 @@ public boolean isWriting() { public void close() { if (!closed) { try { + try { + if (largeBodyReader != null) { + largeBodyReader.close(); + } + } catch (Exception e) { + // if we get an error only at this point, there's nothing else we could do other than log.warn + logger.warn("{}", e.getMessage(), e); + } if (message != null) { message.usageDown(); } } finally { - reset(true); + resetClosed(); } } } @Override - public AMQPLargeMessageWriter open() { - if (!closed) { Review Comment: was an accident I placed it back already Issue Time Tracking ------------------- Worklog Id: (was: 908584) Time Spent: 7h 10m (was: 7h) > Move AMQP Large Message File Handling away from Netty thread > ------------------------------------------------------------ > > Key: ARTEMIS-4668 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4668 > Project: ActiveMQ Artemis > Issue Type: Bug > Affects Versions: 2.32.0 > Reporter: Clebert Suconic > Assignee: Clebert Suconic > Priority: Major > Fix For: 2.33.0 > > Time Spent: 7h 10m > Remaining Estimate: 0h > > Operations like file.open, file.close, and file.sync should be moved away > from the Netty Thread for AMQP Large Messages > This task now is about moving the processing for AMQP Messages. we may in a > near future also improve tunneled large messages. For now we will do for AMQP > messages only. -- This message was sent by Atlassian Jira (v8.20.10#820010)