[
https://issues.apache.org/jira/browse/ARTEMIS-4668?focusedWorklogId=908596&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-908596
]
ASF GitHub Bot logged work on ARTEMIS-4668:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 06/Mar/24 16:25
Start Date: 06/Mar/24 16:25
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4840:
URL: https://github.com/apache/activemq-artemis/pull/4840#discussion_r1514787699
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/AMQPLargeMessageReader.java:
##########
@@ -50,14 +50,15 @@ public DeliveryAnnotations getDeliveryAnnotations() {
@Override
public void close() {
if (!closed) {
- if (currentMessage != null) {
- try {
- currentMessage.deleteFile();
- } catch (Throwable error) {
-
ActiveMQServerLogger.LOGGER.errorDeletingLargeMessageFile(error);
- } finally {
- currentMessage = null;
+ try {
+ AMQPLargeMessage localCurrentMessage = currentMessage;
Review Comment:
@gemmellr actually... I am doing another change instead.
The AMQPLargeMessage should be created within the session executor.
Right now that's only working because I'm not actually creating a file there
yet.. but this is a bit fragile.. as anyone could break it..
I will move the initialization of the new Object within the addBytes..
Issue Time Tracking
-------------------
Worklog Id: (was: 908596)
Time Spent: 8.5h (was: 8h 20m)
> Move AMQP Large Message File Handling away from Netty thread
> ------------------------------------------------------------
>
> Key: ARTEMIS-4668
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4668
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.32.0
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.33.0
>
> Time Spent: 8.5h
> Remaining Estimate: 0h
>
> Operations like file.open, file.close, and file.sync should be moved away
> from the Netty Thread for AMQP Large Messages
> This task now is about moving the processing for AMQP Messages. we may in a
> near future also improve tunneled large messages. For now we will do for AMQP
> messages only.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
