[ 
https://issues.apache.org/jira/browse/ARTEMIS-5266?focusedWorklogId=954563&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-954563
 ]

ASF GitHub Bot logged work on ARTEMIS-5266:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 29/Jan/25 20:57
            Start Date: 29/Jan/25 20:57
    Worklog Time Spent: 10m 
      Work Description: jbertram commented on code in PR #5477:
URL: https://github.com/apache/activemq-artemis/pull/5477#discussion_r1934574172


##########
artemis-commons/src/test/java/org/apache/activemq/artemis/utils/collections/LongHashSetTest.java:
##########
@@ -327,7 +326,7 @@ public void containsEmptySet() {
       final LongHashSet other = new LongHashSet(100);
 
       assertTrue(testSet.containsAll(other));
-      assertTrue(testSet.containsAll((Collection<?>) other));
+      assertTrue(testSet.containsAll(other));

Review Comment:
   Fixed.



##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/largemessages/InterruptedAMQPLargeMessage.java:
##########
@@ -147,7 +147,7 @@ public void testInterruptedLargeMessage() throws Exception {
       AmqpReceiver receiver = session.createReceiver(getQueueName());
 
       int received = 0;
-      receiver.flow((int) (messageCount + 10));
+      receiver.flow((messageCount + 10));

Review Comment:
   Fixed.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 954563)
    Time Spent: 4h 40m  (was: 4.5h)

> Code gardening after move to Java 17
> ------------------------------------
>
>                 Key: ARTEMIS-5266
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-5266
>             Project: ActiveMQ Artemis
>          Issue Type: Task
>            Reporter: Justin Bertram
>            Assignee: Justin Bertram
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 4h 40m
>  Remaining Estimate: 0h
>
> With the recent move to Java 17 now is a good time to do some code gardening 
> to leverage new language features (e.g. text blocks) and deal with old issue 
> (e.g. unused variables, etc.).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact


Reply via email to