[
https://issues.apache.org/jira/browse/ARTEMIS-5266?focusedWorklogId=954517&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-954517
]
ASF GitHub Bot logged work on ARTEMIS-5266:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 29/Jan/25 17:28
Start Date: 29/Jan/25 17:28
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #5477:
URL: https://github.com/apache/activemq-artemis/pull/5477#discussion_r1934304007
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/config/impl/ConfigurationImpl.java:
##########
@@ -744,16 +743,16 @@ public void setProperty(final Object bean, String name,
final Object value) thro
} catch (final NoSuchMethodException e) {
throw new InvocationTargetException(e, "Failed to get
descriptor for: " + name + " on: " + target.getClass());
}
- if (descriptor instanceof MappedPropertyDescriptor) {
- if (((MappedPropertyDescriptor)
descriptor).getMappedWriteMethod() == null) {
+ if (descriptor instanceof MappedPropertyDescriptor
propertyDescriptor) {
+ if (propertyDescriptor.getMappedWriteMethod() == null) {
Review Comment:
This and the leg below could use distinct names, e.g
mappedPropertyDescriptor and indexedPropertyDescriptor, to make things more
readable. Them both using propertyDescriptor now arguably makes it _less_
readable than originally.
Issue Time Tracking
-------------------
Worklog Id: (was: 954517)
Time Spent: 3h 10m (was: 3h)
> Code gardening after move to Java 17
> ------------------------------------
>
> Key: ARTEMIS-5266
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5266
> Project: ActiveMQ Artemis
> Issue Type: Task
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> With the recent move to Java 17 now is a good time to do some code gardening
> to leverage new language features (e.g. text blocks) and deal with old issue
> (e.g. unused variables, etc.).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
