[
https://issues.apache.org/jira/browse/ARTEMIS-5588?focusedWorklogId=984829&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-984829
]
ASF GitHub Bot logged work on ARTEMIS-5588:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 26/Sep/25 20:29
Start Date: 26/Sep/25 20:29
Worklog Time Spent: 10m
Work Description: tabish121 commented on code in PR #5942:
URL: https://github.com/apache/activemq-artemis/pull/5942#discussion_r2383432098
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java:
##########
@@ -4624,9 +4625,14 @@ public void reloadConfigurationFile() throws Exception {
}
private void reloadConfigurationFile(URL uri) throws Exception {
- Configuration config = new
FileConfigurationParser().parseMainConfig(uri.openStream());
- LegacyJMSConfiguration legacyJMSConfiguration = new
LegacyJMSConfiguration(config);
- legacyJMSConfiguration.parseConfiguration(uri.openStream());
+ Configuration config = null;
Review Comment:
This seems like it could put the configuration into a weird state if the
user provided some configuration in a ConfigurationImpl originally and some in
broker properties without using the XML file as any values in the bits that
aren't read from properties but then set onto the old configuration object
using the new initially empty one would blow away any existing values from the
starting ConfigurationImpl. Seems like at the very least we want to document
the limitations.
Issue Time Tracking
-------------------
Worklog Id: (was: 984829)
Time Spent: 20m (was: 10m)
> config reload of properties requires an xml config
> --------------------------------------------------
>
> Key: ARTEMIS-5588
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5588
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Configuration
> Affects Versions: 2.42.0
> Reporter: Gary Tully
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> An embedded broker can work without any xml config and will load broker
> properties to configure as needed, however the config reload for properties
> paths feature is gated on the presence of a config url provided by the xml
> parser.
> reload should be able to work with a null config url.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
