[
https://issues.apache.org/jira/browse/ARTEMIS-5588?focusedWorklogId=985645&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-985645
]
ASF GitHub Bot logged work on ARTEMIS-5588:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 03/Oct/25 13:36
Start Date: 03/Oct/25 13:36
Worklog Time Spent: 10m
Work Description: gtully commented on code in PR #5942:
URL: https://github.com/apache/activemq-artemis/pull/5942#discussion_r2401938960
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java:
##########
@@ -4624,9 +4625,14 @@ public void reloadConfigurationFile() throws Exception {
}
private void reloadConfigurationFile(URL uri) throws Exception {
- Configuration config = new
FileConfigurationParser().parseMainConfig(uri.openStream());
- LegacyJMSConfiguration legacyJMSConfiguration = new
LegacyJMSConfiguration(config);
- legacyJMSConfiguration.parseConfiguration(uri.openStream());
+ Configuration config = null;
Review Comment:
sorry, yes, that config is pointless and potentially wrong when the xml url
is null. I have made all those assignments conditional. thanks for the reviews!
Issue Time Tracking
-------------------
Worklog Id: (was: 985645)
Time Spent: 1h 20m (was: 1h 10m)
> config reload of properties requires an xml config
> --------------------------------------------------
>
> Key: ARTEMIS-5588
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5588
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Configuration
> Affects Versions: 2.42.0
> Reporter: Gary Tully
> Assignee: Gary Tully
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> An embedded broker can work without any xml config and will load broker
> properties to configure as needed, however the config reload for properties
> paths feature is gated on the presence of a config url provided by the xml
> parser.
> reload should be able to work with a null config url.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
