[
https://issues.apache.org/jira/browse/ARTEMIS-5717?focusedWorklogId=989123&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-989123
]
ASF GitHub Bot logged work on ARTEMIS-5717:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 27/Oct/25 20:23
Start Date: 27/Oct/25 20:23
Worklog Time Spent: 10m
Work Description: tabish121 commented on PR #6009:
URL:
https://github.com/apache/activemq-artemis/pull/6009#issuecomment-3453161462
> @tabish121 nicely done...
>
> my only comment is. can you remove these lines now that you are properly
dealing with the routingType on AMQP?
>
>
https://github.com/apache/activemq-artemis/blob/12d45767cb762f4105e041fe8c3e70595dfcb42e/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerSessionImpl.java#L2404-L2411
>
> We don't even have prefixes any more..
>
> this was a question back then about the routing type on the message versus
the link. No more questions as of today after your commit.
I'm happy to remove them. I left them as I was trying to minimize the
footprint of the change but they don't make a ton of sense as the code has been
checking prefix values elsewhere for years.
Issue Time Tracking
-------------------
Worklog Id: (was: 989123)
Time Spent: 2h 10m (was: 2h)
> BrokerConnection Receiver would lose messages on routing type mismatch
> ----------------------------------------------------------------------
>
> Key: ARTEMIS-5717
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5717
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Clebert Suconic
> Assignee: Timothy A. Bish
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.44.0
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
