[ 
https://issues.apache.org/jira/browse/ARTEMIS-5717?focusedWorklogId=989125&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-989125
 ]

ASF GitHub Bot logged work on ARTEMIS-5717:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 27/Oct/25 20:27
            Start Date: 27/Oct/25 20:27
    Worklog Time Spent: 10m 
      Work Description: tabish121 commented on code in PR #6009:
URL: https://github.com/apache/activemq-artemis/pull/6009#discussion_r2466987742


##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerSessionImpl.java:
##########
@@ -2396,10 +2408,20 @@ public synchronized RoutingStatus doSend(final 
Transaction tx,
                                             final String senderName,
                                             final boolean noAutoCreateQueue,
                                             final RoutingContext 
routingContext) throws Exception {
+      return doSend(tx, msg.getRoutingType(), msg, originalAddress, direct, 
senderName, noAutoCreateQueue, routingContext);
+   }
 
-      RoutingStatus result = RoutingStatus.OK;
+   @Override
+   public synchronized RoutingStatus doSend(final Transaction tx,
+                                            final RoutingType routingType,
+                                            final Message message,
+                                            final SimpleString originalAddress,
+                                            final boolean direct,
+                                            final String senderName,
+                                            final boolean noAutoCreateQueue,
+                                            final RoutingContext 
routingContext) throws Exception {
 
-      RoutingType routingType = msg.getRoutingType();
+      RoutingStatus result = RoutingStatus.OK;
 
          /* TODO-now: How to address here with AMQP?

Review Comment:
   Removed





Issue Time Tracking
-------------------

    Worklog Id:     (was: 989125)
    Time Spent: 2.5h  (was: 2h 20m)

> BrokerConnection Receiver would lose messages on routing type mismatch
> ----------------------------------------------------------------------
>
>                 Key: ARTEMIS-5717
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-5717
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Clebert Suconic
>            Assignee: Timothy A. Bish
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 2.44.0
>
>          Time Spent: 2.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to