[
https://issues.apache.org/jira/browse/ARTEMIS-5752?focusedWorklogId=990749&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-990749
]
ASF GitHub Bot logged work on ARTEMIS-5752:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 07/Nov/25 13:31
Start Date: 07/Nov/25 13:31
Worklog Time Spent: 10m
Work Description: gemmellr commented on PR #6034:
URL:
https://github.com/apache/activemq-artemis/pull/6034#issuecomment-3502588517
Your commit message of "Change lineEnding to dos for .cmd files" is a bit
misleading and could be clearer, its strictly doing more than that since it
mandates the endings on the nix script as well. "Set line endings on artemis
scripts in distribution assembly" would be closer to the mark.
Issue Time Tracking
-------------------
Worklog Id: (was: 990749)
Time Spent: 50m (was: 40m)
> Fix line endings
> ----------------
>
> Key: ARTEMIS-5752
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5752
> Project: ActiveMQ Artemis
> Issue Type: Task
> Affects Versions: 2.44.0
> Reporter: Gašper Čefarin
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> An attempt to fix line endings for windows builds by changing
> maven-assembly-plugin's lineEnd settings and adding .gitattributes file.
> git --renormalize was also used to change encodings of some files to LF.
> note: I was not able to change .cmd files' encodings to CRLF in git's index
> ...
> current git ls-files --eol output:
> {code:java}
> git ls-files --eol *.cmd
> i/lf w/crlf attr/text eol=crlf
> artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/bin/artemis.cmd
> i/lf w/crlf attr/text eol=crlf
> artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/artemis-utility.profile.cmd
> i/lf w/crlf attr/text eol=crlf
> artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/artemis.profile.cmd
> i/lf w/crlf attr/text eol=crlf
> artemis-distribution/src/main/resources/bin/artemis.cmd
> i/lf w/crlf attr/text eol=crlf
> tests/smoke-tests/src/main/filtered-resources/servers/windowsUpgrade/bin/artemis.cmd
> i/lf w/crlf attr/text eol=crlf
> tests/smoke-tests/src/main/filtered-resources/servers/windowsUpgradeETC/artemis.profile.cmd{code}
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
