[
https://issues.apache.org/jira/browse/ARTEMIS-5752?focusedWorklogId=990764&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-990764
]
ASF GitHub Bot logged work on ARTEMIS-5752:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 07/Nov/25 16:10
Start Date: 07/Nov/25 16:10
Worklog Time Spent: 10m
Work Description: gemmellr merged PR #6034:
URL: https://github.com/apache/activemq-artemis/pull/6034
Issue Time Tracking
-------------------
Worklog Id: (was: 990764)
Time Spent: 1h 10m (was: 1h)
> Fix line endings
> ----------------
>
> Key: ARTEMIS-5752
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5752
> Project: ActiveMQ Artemis
> Issue Type: Task
> Affects Versions: 2.44.0
> Reporter: Gašper Čefarin
> Priority: Minor
> Labels: pull-request-available
> Fix For: 2.45.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The assembly creation keeps the existing line endings from the checked out
> sources, meaning that when building on some systems the linux script will
> have CRLF endings and then not work correctly when executed on linux. The
> reverse is true of the windows .cmd script but that generally works ok.
> Though this was noticed mostly due to an unexpected git configuration
> (Related discussion:
> [https://lists.apache.org/thread/lrnkjcbf73bkxlk9j5p9m1pxv5djjh2x] ) the
> assembly creation should be tweaked to avoid the general problem from
> occurring, setting the line endings on those scripts during assembly creation
> so that they are appropriate for the respective systems upon execution.
> There are also a handful of files with CRLF line endings in the repo index
> rather than the normalised LF used throughout, flip the endings and
> renormalise so the repo index is consistent.
> == Original description ==
> -An attempt to fix line endings for windows builds by changing
> maven-assembly-plugin's lineEnd settings and adding .gitattributes file.-
> -git --renormalize was also used to change encodings of some files to LF.-
> -note: I was not able to change .cmd files' encodings to CRLF in git's index
> ...-
> -current git ls-files --eol output:-
> {code:java}
> git ls-files --eol *.cmd
> i/lf w/crlf attr/text eol=crlf
> artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/bin/artemis.cmd
> i/lf w/crlf attr/text eol=crlf
> artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/artemis-utility.profile.cmd
> i/lf w/crlf attr/text eol=crlf
> artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/artemis.profile.cmd
> i/lf w/crlf attr/text eol=crlf
> artemis-distribution/src/main/resources/bin/artemis.cmd
> i/lf w/crlf attr/text eol=crlf
> tests/smoke-tests/src/main/filtered-resources/servers/windowsUpgrade/bin/artemis.cmd
> i/lf w/crlf attr/text eol=crlf
> tests/smoke-tests/src/main/filtered-resources/servers/windowsUpgradeETC/artemis.profile.cmd{code}
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
