DImuthuUpe commented on a change in pull request #7:
URL: https://github.com/apache/airavata-mft/pull/7#discussion_r412733587
##########
File path: services/resource-service/stub/src/main/proto/ResourceService.proto
##########
@@ -80,6 +82,10 @@ message SCPResourceDeleteRequest {
string resourceId = 1;
}
+message SCPResourcesGetRequest {
+ string storageId = 1;
Review comment:
Why do you need a storage id?
##########
File path:
services/resource-service/server/src/main/java/org/apache/airavata/mft/resource/server/backend/sql/SQLResourceBackend.java
##########
@@ -195,4 +221,15 @@ public boolean
updateAzureResource(AzureResourceUpdateRequest request) throws Ex
public boolean deleteAzureResource(AzureResourceDeleteRequest request)
throws Exception {
throw new UnsupportedOperationException("Operation is not supported in
backend");
}
+
+ @Override
+ public List<AzureResource> getAzureResources(AzureResourcesGetRequest
request) throws Exception {
+ throw new UnsupportedOperationException("Operation is not supported in
backend");
+ }
+
+ @Override
+ public StorageTypes getStorageTypes() throws Exception {
+ System.out.println("this is sql backend");
Review comment:
Don't use standard outs. Always use logs if you need to print something.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
