aarushiibisht commented on a change in pull request #7:
URL: https://github.com/apache/airavata-mft/pull/7#discussion_r413227263



##########
File path: services/resource-service/stub/src/main/proto/ResourceService.proto
##########
@@ -80,6 +82,10 @@ message SCPResourceDeleteRequest {
     string resourceId = 1;
 }
 
+message SCPResourcesGetRequest {
+    string storageId = 1;

Review comment:
       @DImuthuUpe storageId is to filter the resources in a particular storage 
unit. Correct me if my understanding is wrong. We have different storage types 
like S3, SCP, Azure. There can be multiple storage units of each type eg 
remote-ssh-storage1, remote-ssh-storage. And within each storage unit there are 
resources which user can transfer from one storage unit to another. In the 
admin portal navigation would work as follows: User views all storage units 
available, selects a storage unit to view all the resources within. To request 
for resources within a storage unit, we need an storage identifier. I have only 
added this for SCP resources request since we only have SCP storages 
implemented. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to