DImuthuUpe commented on a change in pull request #11:
URL: https://github.com/apache/airavata-mft/pull/11#discussion_r418649013
##########
File path:
services/resource-service/server/src/main/resources/distribution/conf/resources.json
##########
@@ -59,5 +59,10 @@
"type": "DROPBOX",
"resourceId": "",
"resourcePath": ""
+ },
+ {
+ "type": "GDRIVE",
+ "resourceId": "gdrive-file",
+ "resourcePath": "nsagdrive.txt"
Review comment:
Use the GDrive specific names for the resource parameters. It's not
required to have the resourcePath for all resource types. Only requirements is
to have a resourceId field
##########
File path:
services/secret-service/server/src/main/resources/distribution/conf/secrets.json
##########
@@ -31,5 +31,10 @@
"type": "DROPBOX",
"secretId": "dropbox-cred",
"accessToken": ""
+ },
+ {
+ "type": "GDRIVE",
+ "secretId": "gdrive-cred",
+ "credentialsJson": ""
Review comment:
+1
##########
File path:
transport/gdrive-transport/src/main/java/org/apache/airavata/mft/transport/gdrive/GDriveReceiver.java
##########
@@ -0,0 +1,128 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.airavata.mft.transport.gdrive;
+
+import com.google.api.client.googleapis.auth.oauth2.GoogleCredential;
+import com.google.api.client.googleapis.javanet.GoogleNetHttpTransport;
+import com.google.api.client.http.HttpTransport;
+import com.google.api.client.json.JsonFactory;
+import com.google.api.client.json.jackson2.JacksonFactory;
+import com.google.api.services.drive.Drive;
+import com.google.api.services.drive.DriveScopes;
+import com.google.api.services.drive.model.File;
+import com.google.api.services.drive.model.FileList;
+import org.apache.airavata.mft.core.ConnectorContext;
+import org.apache.airavata.mft.core.api.Connector;
+import org.apache.airavata.mft.resource.client.ResourceServiceClient;
+import org.apache.airavata.mft.resource.service.GDriveResource;
+import org.apache.airavata.mft.resource.service.GDriveResourceGetRequest;
+import org.apache.airavata.mft.resource.service.ResourceServiceGrpc;
+import org.apache.airavata.mft.secret.client.SecretServiceClient;
+import org.apache.airavata.mft.secret.service.GDriveSecret;
+import org.apache.airavata.mft.secret.service.GDriveSecretGetRequest;
+import org.apache.airavata.mft.secret.service.SecretServiceGrpc;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.ByteArrayInputStream;
+import java.io.InputStream;
+import java.io.OutputStream;
+import java.nio.charset.StandardCharsets;
+import java.util.Collection;
+
+public class GDriveReceiver implements Connector {
+
+ private static final Logger logger =
LoggerFactory.getLogger(GDriveReceiver.class);
+
+ private GDriveResource gdriveResource;
+ private Drive drive;
+
+ @Override
+ public void init(String resourceId, String credentialToken, String
resourceServiceHost, int resourceServicePort, String secretServiceHost, int
secretServicePort) throws Exception {
+ ResourceServiceGrpc.ResourceServiceBlockingStub resourceClient =
ResourceServiceClient.buildClient(resourceServiceHost, resourceServicePort);
+ this.gdriveResource =
resourceClient.getGDriveResource(GDriveResourceGetRequest.newBuilder().setResourceId(resourceId).build());
+
+ SecretServiceGrpc.SecretServiceBlockingStub secretClient =
SecretServiceClient.buildClient(secretServiceHost, secretServicePort);
+ GDriveSecret gdriveSecret =
secretClient.getGDriveSecret(GDriveSecretGetRequest.newBuilder().setSecretId(credentialToken).build());
+
+ HttpTransport transport = GoogleNetHttpTransport.newTrustedTransport();
+ JsonFactory jsonFactory = new JacksonFactory();
+ String jsonString = gdriveSecret.getCredentialsJson();
+ GoogleCredential credential = GoogleCredential.fromStream(new
ByteArrayInputStream(jsonString.getBytes(StandardCharsets.UTF_8)), transport,
jsonFactory);
+ if (credential.createScopedRequired()) {
+ Collection<String> scopes = DriveScopes.all();
+ credential = credential.createScoped(scopes);
+ }
+ drive = new Drive.Builder(transport, jsonFactory, credential).build();
+ }
+
+ @Override
+ public void destroy() {
+ }
+
+ @Override
+ public void startStream(ConnectorContext context) throws Exception {
+ logger.info("Starting GDrive Receiver stream for transfer {}",
context.getTransferId());
+
+ String id = null;
+ FileList fileList = drive.files().list()
+ .setQ("name = '"+gdriveResource.getResourcePath()+"'")
Review comment:
Spaces around +
##########
File path:
transport/gdrive-transport/src/main/java/org/apache/airavata/mft/transport/gdrive/GDriveReceiver.java
##########
@@ -0,0 +1,128 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.airavata.mft.transport.gdrive;
+
+import com.google.api.client.googleapis.auth.oauth2.GoogleCredential;
+import com.google.api.client.googleapis.javanet.GoogleNetHttpTransport;
+import com.google.api.client.http.HttpTransport;
+import com.google.api.client.json.JsonFactory;
+import com.google.api.client.json.jackson2.JacksonFactory;
+import com.google.api.services.drive.Drive;
+import com.google.api.services.drive.DriveScopes;
+import com.google.api.services.drive.model.File;
+import com.google.api.services.drive.model.FileList;
+import org.apache.airavata.mft.core.ConnectorContext;
+import org.apache.airavata.mft.core.api.Connector;
+import org.apache.airavata.mft.resource.client.ResourceServiceClient;
+import org.apache.airavata.mft.resource.service.GDriveResource;
+import org.apache.airavata.mft.resource.service.GDriveResourceGetRequest;
+import org.apache.airavata.mft.resource.service.ResourceServiceGrpc;
+import org.apache.airavata.mft.secret.client.SecretServiceClient;
+import org.apache.airavata.mft.secret.service.GDriveSecret;
+import org.apache.airavata.mft.secret.service.GDriveSecretGetRequest;
+import org.apache.airavata.mft.secret.service.SecretServiceGrpc;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.ByteArrayInputStream;
+import java.io.InputStream;
+import java.io.OutputStream;
+import java.nio.charset.StandardCharsets;
+import java.util.Collection;
+
+public class GDriveReceiver implements Connector {
+
+ private static final Logger logger =
LoggerFactory.getLogger(GDriveReceiver.class);
+
+ private GDriveResource gdriveResource;
+ private Drive drive;
+
+ @Override
+ public void init(String resourceId, String credentialToken, String
resourceServiceHost, int resourceServicePort, String secretServiceHost, int
secretServicePort) throws Exception {
+ ResourceServiceGrpc.ResourceServiceBlockingStub resourceClient =
ResourceServiceClient.buildClient(resourceServiceHost, resourceServicePort);
+ this.gdriveResource =
resourceClient.getGDriveResource(GDriveResourceGetRequest.newBuilder().setResourceId(resourceId).build());
+
+ SecretServiceGrpc.SecretServiceBlockingStub secretClient =
SecretServiceClient.buildClient(secretServiceHost, secretServicePort);
+ GDriveSecret gdriveSecret =
secretClient.getGDriveSecret(GDriveSecretGetRequest.newBuilder().setSecretId(credentialToken).build());
+
+ HttpTransport transport = GoogleNetHttpTransport.newTrustedTransport();
+ JsonFactory jsonFactory = new JacksonFactory();
+ String jsonString = gdriveSecret.getCredentialsJson();
+ GoogleCredential credential = GoogleCredential.fromStream(new
ByteArrayInputStream(jsonString.getBytes(StandardCharsets.UTF_8)), transport,
jsonFactory);
+ if (credential.createScopedRequired()) {
+ Collection<String> scopes = DriveScopes.all();
+ credential = credential.createScoped(scopes);
+ }
+ drive = new Drive.Builder(transport, jsonFactory, credential).build();
+ }
+
+ @Override
+ public void destroy() {
+ }
+
+ @Override
+ public void startStream(ConnectorContext context) throws Exception {
+ logger.info("Starting GDrive Receiver stream for transfer {}",
context.getTransferId());
+
+ String id = null;
+ FileList fileList = drive.files().list()
+ .setQ("name = '"+gdriveResource.getResourcePath()+"'")
+ .setFields("files(id,name,modifiedTime,md5Checksum,size)")
+ .execute();
+
+ for (File f : fileList.getFiles()) {
+ id = f.getId();
+ }
+
+ if (id == null) {
+ throw new IllegalStateException("GDrive Receiver was unable to
retrieve the resource");
Review comment:
Provide the resource id in the exception text.
##########
File path:
transport/gdrive-transport/src/main/java/org/apache/airavata/mft/transport/gdrive/GDriveMetadataCollector.java
##########
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.airavata.mft.transport.gdrive;
+
+import com.google.api.client.googleapis.auth.oauth2.GoogleCredential;
+import com.google.api.client.googleapis.javanet.GoogleNetHttpTransport;
+import com.google.api.client.http.HttpTransport;
+import com.google.api.client.json.JsonFactory;
+import com.google.api.client.json.jackson2.JacksonFactory;
+import com.google.api.services.drive.Drive;
+import com.google.api.services.drive.DriveScopes;
+import com.google.api.services.drive.model.File;
+import com.google.api.services.drive.model.FileList;
+import org.apache.airavata.mft.core.ResourceMetadata;
+import org.apache.airavata.mft.core.api.MetadataCollector;
+import org.apache.airavata.mft.resource.client.ResourceServiceClient;
+import org.apache.airavata.mft.resource.service.GDriveResource;
+import org.apache.airavata.mft.resource.service.GDriveResourceGetRequest;
+import org.apache.airavata.mft.resource.service.ResourceServiceGrpc;
+import org.apache.airavata.mft.secret.client.SecretServiceClient;
+import org.apache.airavata.mft.secret.service.GDriveSecret;
+import org.apache.airavata.mft.secret.service.GDriveSecretGetRequest;
+import org.apache.airavata.mft.secret.service.SecretServiceGrpc;
+
+import java.io.ByteArrayInputStream;
+import java.nio.charset.StandardCharsets;
+import java.util.Collection;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class GDriveMetadataCollector implements MetadataCollector {
+
+ private String resourceServiceHost;
+ private int resourceServicePort;
+ private String secretServiceHost;
+ private int secretServicePort;
+ boolean initialized = false;
+
+ private static final Logger logger =
LoggerFactory.getLogger(GDriveMetadataCollector.class);
+
+
+ @Override
+ public void init(String resourceServiceHost, int resourceServicePort,
String secretServiceHost, int secretServicePort) {
+ this.resourceServiceHost = resourceServiceHost;
+ this.resourceServicePort = resourceServicePort;
+ this.secretServiceHost = secretServiceHost;
+ this.secretServicePort = secretServicePort;
+ this.initialized = true;
+ }
+
+
+ private void checkInitialized() {
+ if (!initialized) {
+ throw new IllegalStateException("GDrive Metadata Collector is not
initialized");
+ }
+ }
+
+ @Override
+ public ResourceMetadata getGetResourceMetadata(String resourceId, String
credentialToken) throws Exception {
+ checkInitialized();
+ ResourceServiceGrpc.ResourceServiceBlockingStub resourceClient =
ResourceServiceClient.buildClient(resourceServiceHost, resourceServicePort);
+ GDriveResource gdriveResource =
resourceClient.getGDriveResource(GDriveResourceGetRequest.newBuilder().setResourceId(resourceId).build());
+
+ SecretServiceGrpc.SecretServiceBlockingStub secretClient =
SecretServiceClient.buildClient(secretServiceHost, secretServicePort);
+ GDriveSecret gdriveSecret =
secretClient.getGDriveSecret(GDriveSecretGetRequest.newBuilder().setSecretId(credentialToken).build());
+
+
+ HttpTransport transport = GoogleNetHttpTransport.newTrustedTransport();
+ JsonFactory jsonFactory = new JacksonFactory();
+ String jsonString = gdriveSecret.getCredentialsJson();
+ GoogleCredential credential = GoogleCredential.fromStream(new
ByteArrayInputStream(jsonString.getBytes(StandardCharsets.UTF_8)), transport,
jsonFactory);
+ if (credential.createScopedRequired()) {
+ Collection<String> scopes = DriveScopes.all();
+ credential = credential.createScoped(scopes);
+ }
+
+ Drive drive = new Drive.Builder(transport, jsonFactory,
credential).build();
+ ResourceMetadata metadata = new ResourceMetadata();
+ FileList fileList = drive.files().list()
+ .setQ("name = '"+gdriveResource.getResourcePath()+"'")
+
.setFields("files(id,name,modifiedTime,md5Checksum,size,mimeType)")
+ .execute();
+
+ for (File f : fileList.getFiles()) {
Review comment:
Shouldn't we expect only one entry in flieList? Do a validation before
this point
##########
File path:
transport/gdrive-transport/src/main/java/org/apache/airavata/mft/transport/gdrive/GDriveMetadataCollector.java
##########
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.airavata.mft.transport.gdrive;
+
+import com.google.api.client.googleapis.auth.oauth2.GoogleCredential;
+import com.google.api.client.googleapis.javanet.GoogleNetHttpTransport;
+import com.google.api.client.http.HttpTransport;
+import com.google.api.client.json.JsonFactory;
+import com.google.api.client.json.jackson2.JacksonFactory;
+import com.google.api.services.drive.Drive;
+import com.google.api.services.drive.DriveScopes;
+import com.google.api.services.drive.model.File;
+import com.google.api.services.drive.model.FileList;
+import org.apache.airavata.mft.core.ResourceMetadata;
+import org.apache.airavata.mft.core.api.MetadataCollector;
+import org.apache.airavata.mft.resource.client.ResourceServiceClient;
+import org.apache.airavata.mft.resource.service.GDriveResource;
+import org.apache.airavata.mft.resource.service.GDriveResourceGetRequest;
+import org.apache.airavata.mft.resource.service.ResourceServiceGrpc;
+import org.apache.airavata.mft.secret.client.SecretServiceClient;
+import org.apache.airavata.mft.secret.service.GDriveSecret;
+import org.apache.airavata.mft.secret.service.GDriveSecretGetRequest;
+import org.apache.airavata.mft.secret.service.SecretServiceGrpc;
+
+import java.io.ByteArrayInputStream;
+import java.nio.charset.StandardCharsets;
+import java.util.Collection;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class GDriveMetadataCollector implements MetadataCollector {
+
+ private String resourceServiceHost;
+ private int resourceServicePort;
+ private String secretServiceHost;
+ private int secretServicePort;
+ boolean initialized = false;
+
+ private static final Logger logger =
LoggerFactory.getLogger(GDriveMetadataCollector.class);
+
+
+ @Override
+ public void init(String resourceServiceHost, int resourceServicePort,
String secretServiceHost, int secretServicePort) {
+ this.resourceServiceHost = resourceServiceHost;
+ this.resourceServicePort = resourceServicePort;
+ this.secretServiceHost = secretServiceHost;
+ this.secretServicePort = secretServicePort;
+ this.initialized = true;
+ }
+
+
+ private void checkInitialized() {
+ if (!initialized) {
+ throw new IllegalStateException("GDrive Metadata Collector is not
initialized");
+ }
+ }
+
+ @Override
+ public ResourceMetadata getGetResourceMetadata(String resourceId, String
credentialToken) throws Exception {
+ checkInitialized();
+ ResourceServiceGrpc.ResourceServiceBlockingStub resourceClient =
ResourceServiceClient.buildClient(resourceServiceHost, resourceServicePort);
+ GDriveResource gdriveResource =
resourceClient.getGDriveResource(GDriveResourceGetRequest.newBuilder().setResourceId(resourceId).build());
+
+ SecretServiceGrpc.SecretServiceBlockingStub secretClient =
SecretServiceClient.buildClient(secretServiceHost, secretServicePort);
+ GDriveSecret gdriveSecret =
secretClient.getGDriveSecret(GDriveSecretGetRequest.newBuilder().setSecretId(credentialToken).build());
+
+
+ HttpTransport transport = GoogleNetHttpTransport.newTrustedTransport();
+ JsonFactory jsonFactory = new JacksonFactory();
+ String jsonString = gdriveSecret.getCredentialsJson();
+ GoogleCredential credential = GoogleCredential.fromStream(new
ByteArrayInputStream(jsonString.getBytes(StandardCharsets.UTF_8)), transport,
jsonFactory);
+ if (credential.createScopedRequired()) {
+ Collection<String> scopes = DriveScopes.all();
+ credential = credential.createScoped(scopes);
+ }
+
+ Drive drive = new Drive.Builder(transport, jsonFactory,
credential).build();
+ ResourceMetadata metadata = new ResourceMetadata();
+ FileList fileList = drive.files().list()
+ .setQ("name = '"+gdriveResource.getResourcePath()+"'")
+
.setFields("files(id,name,modifiedTime,md5Checksum,size,mimeType)")
+ .execute();
+
+ for (File f : fileList.getFiles()) {
Review comment:
Are you rewriting the metadata again and again?
##########
File path:
transport/gdrive-transport/src/main/java/org/apache/airavata/mft/transport/gdrive/GDriveMetadataCollector.java
##########
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.airavata.mft.transport.gdrive;
+
+import com.google.api.client.googleapis.auth.oauth2.GoogleCredential;
+import com.google.api.client.googleapis.javanet.GoogleNetHttpTransport;
+import com.google.api.client.http.HttpTransport;
+import com.google.api.client.json.JsonFactory;
+import com.google.api.client.json.jackson2.JacksonFactory;
+import com.google.api.services.drive.Drive;
+import com.google.api.services.drive.DriveScopes;
+import com.google.api.services.drive.model.File;
+import com.google.api.services.drive.model.FileList;
+import org.apache.airavata.mft.core.ResourceMetadata;
+import org.apache.airavata.mft.core.api.MetadataCollector;
+import org.apache.airavata.mft.resource.client.ResourceServiceClient;
+import org.apache.airavata.mft.resource.service.GDriveResource;
+import org.apache.airavata.mft.resource.service.GDriveResourceGetRequest;
+import org.apache.airavata.mft.resource.service.ResourceServiceGrpc;
+import org.apache.airavata.mft.secret.client.SecretServiceClient;
+import org.apache.airavata.mft.secret.service.GDriveSecret;
+import org.apache.airavata.mft.secret.service.GDriveSecretGetRequest;
+import org.apache.airavata.mft.secret.service.SecretServiceGrpc;
+
+import java.io.ByteArrayInputStream;
+import java.nio.charset.StandardCharsets;
+import java.util.Collection;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class GDriveMetadataCollector implements MetadataCollector {
+
+ private String resourceServiceHost;
+ private int resourceServicePort;
+ private String secretServiceHost;
+ private int secretServicePort;
+ boolean initialized = false;
+
+ private static final Logger logger =
LoggerFactory.getLogger(GDriveMetadataCollector.class);
+
+
+ @Override
+ public void init(String resourceServiceHost, int resourceServicePort,
String secretServiceHost, int secretServicePort) {
+ this.resourceServiceHost = resourceServiceHost;
+ this.resourceServicePort = resourceServicePort;
+ this.secretServiceHost = secretServiceHost;
+ this.secretServicePort = secretServicePort;
+ this.initialized = true;
+ }
+
+
+ private void checkInitialized() {
+ if (!initialized) {
+ throw new IllegalStateException("GDrive Metadata Collector is not
initialized");
+ }
+ }
+
+ @Override
+ public ResourceMetadata getGetResourceMetadata(String resourceId, String
credentialToken) throws Exception {
+ checkInitialized();
+ ResourceServiceGrpc.ResourceServiceBlockingStub resourceClient =
ResourceServiceClient.buildClient(resourceServiceHost, resourceServicePort);
+ GDriveResource gdriveResource =
resourceClient.getGDriveResource(GDriveResourceGetRequest.newBuilder().setResourceId(resourceId).build());
+
+ SecretServiceGrpc.SecretServiceBlockingStub secretClient =
SecretServiceClient.buildClient(secretServiceHost, secretServicePort);
+ GDriveSecret gdriveSecret =
secretClient.getGDriveSecret(GDriveSecretGetRequest.newBuilder().setSecretId(credentialToken).build());
+
+
+ HttpTransport transport = GoogleNetHttpTransport.newTrustedTransport();
+ JsonFactory jsonFactory = new JacksonFactory();
+ String jsonString = gdriveSecret.getCredentialsJson();
+ GoogleCredential credential = GoogleCredential.fromStream(new
ByteArrayInputStream(jsonString.getBytes(StandardCharsets.UTF_8)), transport,
jsonFactory);
+ if (credential.createScopedRequired()) {
+ Collection<String> scopes = DriveScopes.all();
+ credential = credential.createScoped(scopes);
+ }
+
+ Drive drive = new Drive.Builder(transport, jsonFactory,
credential).build();
+ ResourceMetadata metadata = new ResourceMetadata();
+ FileList fileList = drive.files().list()
+ .setQ("name = '"+gdriveResource.getResourcePath()+"'")
+
.setFields("files(id,name,modifiedTime,md5Checksum,size,mimeType)")
+ .execute();
+
+ for (File f : fileList.getFiles()) {
+ metadata.setMd5sum(f.getMd5Checksum());
+ metadata.setUpdateTime(f.getModifiedTime().getValue());
+ metadata.setResourceSize(f.getSize().longValue());
+ }
+
+ return metadata;
+ }
+
+ @Override
+ public Boolean isAvailable(String resourceId, String credentialToken)
throws Exception {
+ checkInitialized();
+ String id = null;
+ ResourceServiceGrpc.ResourceServiceBlockingStub resourceClient =
ResourceServiceClient.buildClient(resourceServiceHost, resourceServicePort);
+ GDriveResource gdriveResource =
resourceClient.getGDriveResource(GDriveResourceGetRequest.newBuilder().setResourceId(resourceId).build());
+
+ SecretServiceGrpc.SecretServiceBlockingStub secretClient =
SecretServiceClient.buildClient(secretServiceHost, secretServicePort);
+ GDriveSecret gdriveSecret =
secretClient.getGDriveSecret(GDriveSecretGetRequest.newBuilder().setSecretId(credentialToken).build());
+
+
+ HttpTransport transport = GoogleNetHttpTransport.newTrustedTransport();
+ JsonFactory jsonFactory = new JacksonFactory();
+ String jsonString = gdriveSecret.getCredentialsJson();
+ GoogleCredential credential = GoogleCredential.fromStream(new
ByteArrayInputStream(jsonString.getBytes(StandardCharsets.UTF_8)), transport,
jsonFactory);
+ if (credential.createScopedRequired()) {
+ Collection<String> scopes = DriveScopes.all();
+ credential = credential.createScoped(scopes);
+ }
+
+ Drive drive = new Drive.Builder(transport, jsonFactory,
credential).build();
+
+ FileList fileList = drive.files().list()
+ .setQ("name = '"+gdriveResource.getResourcePath()+"'")
Review comment:
Spaces around +
##########
File path:
transport/gdrive-transport/src/main/java/org/apache/airavata/mft/transport/gdrive/GDriveMetadataCollector.java
##########
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.airavata.mft.transport.gdrive;
+
+import com.google.api.client.googleapis.auth.oauth2.GoogleCredential;
+import com.google.api.client.googleapis.javanet.GoogleNetHttpTransport;
+import com.google.api.client.http.HttpTransport;
+import com.google.api.client.json.JsonFactory;
+import com.google.api.client.json.jackson2.JacksonFactory;
+import com.google.api.services.drive.Drive;
+import com.google.api.services.drive.DriveScopes;
+import com.google.api.services.drive.model.File;
+import com.google.api.services.drive.model.FileList;
+import org.apache.airavata.mft.core.ResourceMetadata;
+import org.apache.airavata.mft.core.api.MetadataCollector;
+import org.apache.airavata.mft.resource.client.ResourceServiceClient;
+import org.apache.airavata.mft.resource.service.GDriveResource;
+import org.apache.airavata.mft.resource.service.GDriveResourceGetRequest;
+import org.apache.airavata.mft.resource.service.ResourceServiceGrpc;
+import org.apache.airavata.mft.secret.client.SecretServiceClient;
+import org.apache.airavata.mft.secret.service.GDriveSecret;
+import org.apache.airavata.mft.secret.service.GDriveSecretGetRequest;
+import org.apache.airavata.mft.secret.service.SecretServiceGrpc;
+
+import java.io.ByteArrayInputStream;
+import java.nio.charset.StandardCharsets;
+import java.util.Collection;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class GDriveMetadataCollector implements MetadataCollector {
+
+ private String resourceServiceHost;
+ private int resourceServicePort;
+ private String secretServiceHost;
+ private int secretServicePort;
+ boolean initialized = false;
+
+ private static final Logger logger =
LoggerFactory.getLogger(GDriveMetadataCollector.class);
+
+
+ @Override
+ public void init(String resourceServiceHost, int resourceServicePort,
String secretServiceHost, int secretServicePort) {
+ this.resourceServiceHost = resourceServiceHost;
+ this.resourceServicePort = resourceServicePort;
+ this.secretServiceHost = secretServiceHost;
+ this.secretServicePort = secretServicePort;
+ this.initialized = true;
+ }
+
+
+ private void checkInitialized() {
+ if (!initialized) {
+ throw new IllegalStateException("GDrive Metadata Collector is not
initialized");
+ }
+ }
+
+ @Override
+ public ResourceMetadata getGetResourceMetadata(String resourceId, String
credentialToken) throws Exception {
+ checkInitialized();
+ ResourceServiceGrpc.ResourceServiceBlockingStub resourceClient =
ResourceServiceClient.buildClient(resourceServiceHost, resourceServicePort);
+ GDriveResource gdriveResource =
resourceClient.getGDriveResource(GDriveResourceGetRequest.newBuilder().setResourceId(resourceId).build());
+
+ SecretServiceGrpc.SecretServiceBlockingStub secretClient =
SecretServiceClient.buildClient(secretServiceHost, secretServicePort);
+ GDriveSecret gdriveSecret =
secretClient.getGDriveSecret(GDriveSecretGetRequest.newBuilder().setSecretId(credentialToken).build());
+
+
+ HttpTransport transport = GoogleNetHttpTransport.newTrustedTransport();
+ JsonFactory jsonFactory = new JacksonFactory();
+ String jsonString = gdriveSecret.getCredentialsJson();
+ GoogleCredential credential = GoogleCredential.fromStream(new
ByteArrayInputStream(jsonString.getBytes(StandardCharsets.UTF_8)), transport,
jsonFactory);
+ if (credential.createScopedRequired()) {
+ Collection<String> scopes = DriveScopes.all();
+ credential = credential.createScoped(scopes);
+ }
+
+ Drive drive = new Drive.Builder(transport, jsonFactory,
credential).build();
+ ResourceMetadata metadata = new ResourceMetadata();
+ FileList fileList = drive.files().list()
+ .setQ("name = '"+gdriveResource.getResourcePath()+"'")
+
.setFields("files(id,name,modifiedTime,md5Checksum,size,mimeType)")
+ .execute();
+
+ for (File f : fileList.getFiles()) {
+ metadata.setMd5sum(f.getMd5Checksum());
+ metadata.setUpdateTime(f.getModifiedTime().getValue());
+ metadata.setResourceSize(f.getSize().longValue());
+ }
+
+ return metadata;
+ }
+
+ @Override
+ public Boolean isAvailable(String resourceId, String credentialToken)
throws Exception {
+ checkInitialized();
+ String id = null;
+ ResourceServiceGrpc.ResourceServiceBlockingStub resourceClient =
ResourceServiceClient.buildClient(resourceServiceHost, resourceServicePort);
+ GDriveResource gdriveResource =
resourceClient.getGDriveResource(GDriveResourceGetRequest.newBuilder().setResourceId(resourceId).build());
+
+ SecretServiceGrpc.SecretServiceBlockingStub secretClient =
SecretServiceClient.buildClient(secretServiceHost, secretServicePort);
+ GDriveSecret gdriveSecret =
secretClient.getGDriveSecret(GDriveSecretGetRequest.newBuilder().setSecretId(credentialToken).build());
+
+
+ HttpTransport transport = GoogleNetHttpTransport.newTrustedTransport();
+ JsonFactory jsonFactory = new JacksonFactory();
+ String jsonString = gdriveSecret.getCredentialsJson();
+ GoogleCredential credential = GoogleCredential.fromStream(new
ByteArrayInputStream(jsonString.getBytes(StandardCharsets.UTF_8)), transport,
jsonFactory);
+ if (credential.createScopedRequired()) {
+ Collection<String> scopes = DriveScopes.all();
+ credential = credential.createScoped(scopes);
+ }
+
+ Drive drive = new Drive.Builder(transport, jsonFactory,
credential).build();
+
+ FileList fileList = drive.files().list()
+ .setQ("name = '"+gdriveResource.getResourcePath()+"'")
+ .setFields("files(id,name)")
+ .execute();
+
+ for (File f : fileList.getFiles()) {
Review comment:
Validate for fileList.getFiles() empty and having more than 1 entry
##########
File path:
transport/gdrive-transport/src/main/java/org/apache/airavata/mft/transport/gdrive/GDriveSender.java
##########
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.airavata.mft.transport.gdrive;
+
+import com.google.api.client.googleapis.auth.oauth2.GoogleCredential;
+import com.google.api.client.googleapis.javanet.GoogleNetHttpTransport;
+import com.google.api.client.http.HttpTransport;
+import com.google.api.client.http.InputStreamContent;
+import com.google.api.client.json.JsonFactory;
+import com.google.api.client.json.jackson2.JacksonFactory;
+import com.google.api.services.drive.Drive;
+import com.google.api.services.drive.DriveScopes;
+import com.google.api.services.drive.model.File;
+import com.google.api.services.drive.model.FileList;
+import com.google.api.services.drive.model.Permission;
+import com.google.gson.JsonObject;
+import com.google.gson.JsonParser;
+import org.apache.airavata.mft.core.ConnectorContext;
+import org.apache.airavata.mft.core.api.Connector;
+import org.apache.airavata.mft.resource.client.ResourceServiceClient;
+import org.apache.airavata.mft.resource.service.GDriveResource;
+import org.apache.airavata.mft.resource.service.GDriveResourceGetRequest;
+import org.apache.airavata.mft.resource.service.ResourceServiceGrpc;
+import org.apache.airavata.mft.secret.client.SecretServiceClient;
+import org.apache.airavata.mft.secret.service.GDriveSecret;
+import org.apache.airavata.mft.secret.service.GDriveSecretGetRequest;
+import org.apache.airavata.mft.secret.service.SecretServiceGrpc;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.ByteArrayInputStream;
+import java.nio.charset.StandardCharsets;
+import java.util.Collection;
+
+
+public class GDriveSender implements Connector {
+ private static final Logger logger =
LoggerFactory.getLogger(GDriveSender.class);
+
+ private GDriveResource gdriveResource;
+ private Drive drive;
+ private JsonObject jsonObject;
+
+
+ @Override
+ public void init(String resourceId, String credentialToken, String
resourceServiceHost, int resourceServicePort, String secretServiceHost, int
secretServicePort) throws Exception {
+ ResourceServiceGrpc.ResourceServiceBlockingStub resourceClient =
ResourceServiceClient.buildClient(resourceServiceHost, resourceServicePort);
+ this.gdriveResource =
resourceClient.getGDriveResource(GDriveResourceGetRequest.newBuilder().setResourceId(resourceId).build());
+
+ SecretServiceGrpc.SecretServiceBlockingStub secretClient =
SecretServiceClient.buildClient(secretServiceHost, secretServicePort);
+ GDriveSecret gdriveSecret =
secretClient.getGDriveSecret(GDriveSecretGetRequest.newBuilder().setSecretId(credentialToken).build());
+
+ HttpTransport transport = GoogleNetHttpTransport.newTrustedTransport();
+ JsonFactory jsonFactory = new JacksonFactory();
+ String jsonString = gdriveSecret.getCredentialsJson();
+ jsonObject = new JsonParser().parse(jsonString).getAsJsonObject();
+ GoogleCredential credential = GoogleCredential.fromStream(new
ByteArrayInputStream(jsonString.getBytes(StandardCharsets.UTF_8)), transport,
jsonFactory);
+
+ if (credential.createScopedRequired()) {
+ Collection<String> scopes = DriveScopes.all();
+ credential = credential.createScoped(scopes);
+ }
+
+ drive = new Drive.Builder(transport, jsonFactory, credential).build();
+
+ }
+
+ @Override
+ public void destroy() {
+
+ }
+
+ @Override
+ public void startStream(ConnectorContext context) throws Exception {
+ logger.info("Starting GDrive send for remote server for transfer {} ",
context.getTransferId());
+ String id = null;
+ boolean fileupdated = false;
+ String entityUser = jsonObject.get("client_email").getAsString();
+ File fileMetadata = new File();
+
+ InputStreamContent contentStream = new InputStreamContent(
Review comment:
Make this one line
##########
File path:
transport/gdrive-transport/src/main/java/org/apache/airavata/mft/transport/gdrive/GDriveSender.java
##########
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.airavata.mft.transport.gdrive;
+
+import com.google.api.client.googleapis.auth.oauth2.GoogleCredential;
+import com.google.api.client.googleapis.javanet.GoogleNetHttpTransport;
+import com.google.api.client.http.HttpTransport;
+import com.google.api.client.http.InputStreamContent;
+import com.google.api.client.json.JsonFactory;
+import com.google.api.client.json.jackson2.JacksonFactory;
+import com.google.api.services.drive.Drive;
+import com.google.api.services.drive.DriveScopes;
+import com.google.api.services.drive.model.File;
+import com.google.api.services.drive.model.FileList;
+import com.google.api.services.drive.model.Permission;
+import com.google.gson.JsonObject;
+import com.google.gson.JsonParser;
+import org.apache.airavata.mft.core.ConnectorContext;
+import org.apache.airavata.mft.core.api.Connector;
+import org.apache.airavata.mft.resource.client.ResourceServiceClient;
+import org.apache.airavata.mft.resource.service.GDriveResource;
+import org.apache.airavata.mft.resource.service.GDriveResourceGetRequest;
+import org.apache.airavata.mft.resource.service.ResourceServiceGrpc;
+import org.apache.airavata.mft.secret.client.SecretServiceClient;
+import org.apache.airavata.mft.secret.service.GDriveSecret;
+import org.apache.airavata.mft.secret.service.GDriveSecretGetRequest;
+import org.apache.airavata.mft.secret.service.SecretServiceGrpc;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.ByteArrayInputStream;
+import java.nio.charset.StandardCharsets;
+import java.util.Collection;
+
+
+public class GDriveSender implements Connector {
+ private static final Logger logger =
LoggerFactory.getLogger(GDriveSender.class);
+
+ private GDriveResource gdriveResource;
+ private Drive drive;
+ private JsonObject jsonObject;
+
+
+ @Override
+ public void init(String resourceId, String credentialToken, String
resourceServiceHost, int resourceServicePort, String secretServiceHost, int
secretServicePort) throws Exception {
+ ResourceServiceGrpc.ResourceServiceBlockingStub resourceClient =
ResourceServiceClient.buildClient(resourceServiceHost, resourceServicePort);
+ this.gdriveResource =
resourceClient.getGDriveResource(GDriveResourceGetRequest.newBuilder().setResourceId(resourceId).build());
+
+ SecretServiceGrpc.SecretServiceBlockingStub secretClient =
SecretServiceClient.buildClient(secretServiceHost, secretServicePort);
+ GDriveSecret gdriveSecret =
secretClient.getGDriveSecret(GDriveSecretGetRequest.newBuilder().setSecretId(credentialToken).build());
+
+ HttpTransport transport = GoogleNetHttpTransport.newTrustedTransport();
+ JsonFactory jsonFactory = new JacksonFactory();
+ String jsonString = gdriveSecret.getCredentialsJson();
+ jsonObject = new JsonParser().parse(jsonString).getAsJsonObject();
+ GoogleCredential credential = GoogleCredential.fromStream(new
ByteArrayInputStream(jsonString.getBytes(StandardCharsets.UTF_8)), transport,
jsonFactory);
+
+ if (credential.createScopedRequired()) {
+ Collection<String> scopes = DriveScopes.all();
+ credential = credential.createScoped(scopes);
+ }
+
+ drive = new Drive.Builder(transport, jsonFactory, credential).build();
+
+ }
+
+ @Override
+ public void destroy() {
+
+ }
+
+ @Override
+ public void startStream(ConnectorContext context) throws Exception {
+ logger.info("Starting GDrive send for remote server for transfer {} ",
context.getTransferId());
+ String id = null;
+ boolean fileupdated = false;
+ String entityUser = jsonObject.get("client_email").getAsString();
+ File fileMetadata = new File();
+
+ InputStreamContent contentStream = new InputStreamContent(
+ "", context.getStreamBuffer().getInputStream());
+
+
+ fileMetadata.setName(this.gdriveResource.getResourcePath());
+ FileList fileList = drive.files().list()
+ .setQ("name = '"+gdriveResource.getResourcePath()+"'")
+ .setFields("files(id,name)")
+ .execute();
+
+ for (File f : fileList.getFiles()) {
Review comment:
validate fileList.getFiles() as I have mentioned before
##########
File path:
transport/gdrive-transport/src/main/java/org/apache/airavata/mft/transport/gdrive/GDriveSender.java
##########
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.airavata.mft.transport.gdrive;
+
+import com.google.api.client.googleapis.auth.oauth2.GoogleCredential;
+import com.google.api.client.googleapis.javanet.GoogleNetHttpTransport;
+import com.google.api.client.http.HttpTransport;
+import com.google.api.client.http.InputStreamContent;
+import com.google.api.client.json.JsonFactory;
+import com.google.api.client.json.jackson2.JacksonFactory;
+import com.google.api.services.drive.Drive;
+import com.google.api.services.drive.DriveScopes;
+import com.google.api.services.drive.model.File;
+import com.google.api.services.drive.model.FileList;
+import com.google.api.services.drive.model.Permission;
+import com.google.gson.JsonObject;
+import com.google.gson.JsonParser;
+import org.apache.airavata.mft.core.ConnectorContext;
+import org.apache.airavata.mft.core.api.Connector;
+import org.apache.airavata.mft.resource.client.ResourceServiceClient;
+import org.apache.airavata.mft.resource.service.GDriveResource;
+import org.apache.airavata.mft.resource.service.GDriveResourceGetRequest;
+import org.apache.airavata.mft.resource.service.ResourceServiceGrpc;
+import org.apache.airavata.mft.secret.client.SecretServiceClient;
+import org.apache.airavata.mft.secret.service.GDriveSecret;
+import org.apache.airavata.mft.secret.service.GDriveSecretGetRequest;
+import org.apache.airavata.mft.secret.service.SecretServiceGrpc;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.ByteArrayInputStream;
+import java.nio.charset.StandardCharsets;
+import java.util.Collection;
+
+
+public class GDriveSender implements Connector {
+ private static final Logger logger =
LoggerFactory.getLogger(GDriveSender.class);
+
+ private GDriveResource gdriveResource;
+ private Drive drive;
+ private JsonObject jsonObject;
+
+
+ @Override
+ public void init(String resourceId, String credentialToken, String
resourceServiceHost, int resourceServicePort, String secretServiceHost, int
secretServicePort) throws Exception {
+ ResourceServiceGrpc.ResourceServiceBlockingStub resourceClient =
ResourceServiceClient.buildClient(resourceServiceHost, resourceServicePort);
+ this.gdriveResource =
resourceClient.getGDriveResource(GDriveResourceGetRequest.newBuilder().setResourceId(resourceId).build());
+
+ SecretServiceGrpc.SecretServiceBlockingStub secretClient =
SecretServiceClient.buildClient(secretServiceHost, secretServicePort);
+ GDriveSecret gdriveSecret =
secretClient.getGDriveSecret(GDriveSecretGetRequest.newBuilder().setSecretId(credentialToken).build());
+
+ HttpTransport transport = GoogleNetHttpTransport.newTrustedTransport();
+ JsonFactory jsonFactory = new JacksonFactory();
+ String jsonString = gdriveSecret.getCredentialsJson();
+ jsonObject = new JsonParser().parse(jsonString).getAsJsonObject();
+ GoogleCredential credential = GoogleCredential.fromStream(new
ByteArrayInputStream(jsonString.getBytes(StandardCharsets.UTF_8)), transport,
jsonFactory);
+
+ if (credential.createScopedRequired()) {
+ Collection<String> scopes = DriveScopes.all();
+ credential = credential.createScoped(scopes);
+ }
+
+ drive = new Drive.Builder(transport, jsonFactory, credential).build();
+
+ }
+
+ @Override
+ public void destroy() {
+
+ }
+
+ @Override
+ public void startStream(ConnectorContext context) throws Exception {
+ logger.info("Starting GDrive send for remote server for transfer {} ",
context.getTransferId());
+ String id = null;
+ boolean fileupdated = false;
+ String entityUser = jsonObject.get("client_email").getAsString();
+ File fileMetadata = new File();
+
+ InputStreamContent contentStream = new InputStreamContent(
+ "", context.getStreamBuffer().getInputStream());
+
+
+ fileMetadata.setName(this.gdriveResource.getResourcePath());
+ FileList fileList = drive.files().list()
+ .setQ("name = '"+gdriveResource.getResourcePath()+"'")
+ .setFields("files(id,name)")
+ .execute();
+
+ for (File f : fileList.getFiles()) {
+ id = f.getId();
+ File file = drive.files().get(id).execute();
+ drive.files().update(file.getId(), fileMetadata,
contentStream).setFields("id").execute();
+ fileupdated = true;
+ }
+
+ if (fileupdated == false) {
Review comment:
What is this logic doing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
