dinukadesilva commented on a change in pull request #11:
URL: https://github.com/apache/airavata-mft/pull/11#discussion_r418664322
##########
File path:
services/secret-service/server/src/main/resources/distribution/conf/secrets.json
##########
@@ -31,5 +31,10 @@
"type": "DROPBOX",
"secretId": "dropbox-cred",
"accessToken": ""
+ },
+ {
+ "type": "GDRIVE",
+ "secretId": "gdrive-cred",
+ "credentialsJson": ""
Review comment:
I feel better if a temporary access token can be saved on the secret and
use that to access the file. That's how it's done in box too. So, later once a
browser component for mft is available, the oauth flow can be added.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
