[ https://issues.apache.org/jira/browse/AMBARI-19149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15762051#comment-15762051 ]
Hadoop QA commented on AMBARI-19149: ------------------------------------ {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12843917/AMBARI-19149-5.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in ambari-server. Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/9732//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/9732//console This message is automatically generated. > Clean up Ambari Server source code warnings > ------------------------------------------- > > Key: AMBARI-19149 > URL: https://issues.apache.org/jira/browse/AMBARI-19149 > Project: Ambari > Issue Type: Task > Components: ambari-server > Reporter: Doroszlai, Attila > Assignee: Doroszlai, Attila > Fix For: 3.0.0 > > Attachments: AMBARI-19149-1.patch, AMBARI-19149-3.patch, > AMBARI-19149-4.patch, AMBARI-19149-5.patch, IDEA_Ambari_v1.xml > > > Eclipse's default warnings generated for {{ambari-server}} number roughly > over 3300. Out of these, at least half of them are: > * Unused imports > * Type safety due to forgotten {{<>}} > * Missing Serialization IDs from anonymous {{HashMap}} implementations > * Unused variables > * {{Capture<T>}} in tests > * {{switch}} fall-through and missing {{case statements}}: *only makes > changes which won't affect existing functionality* > This makes spotting actual problems, like missing {{case}} statements a > nightmare. We need to go through and clean out as many of these warnings as > possible. > Note: With respect to the import cleanup, the IDE of choice should have the > following import order setup. They should always be expanded and never use > {{*}}. > # {{java}} > # {{javax}} > # {{org}} > # {{com}} > # other -- This message was sent by Atlassian JIRA (v6.3.4#6332)