[
https://issues.apache.org/jira/browse/AMBARI-19149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15765554#comment-15765554
]
Hudson commented on AMBARI-19149:
---------------------------------
SUCCESS: Integrated in Jenkins build Ambari-trunk-Commit #6269 (See
[https://builds.apache.org/job/Ambari-trunk-Commit/6269/])
AMBARI-19149. Code cleanup: apply checks to test sources (Attila (ncole:
[http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=4fc52a61f5515780a85d54051bfbb08ba7e530b1])
* (edit) ambari-project/pom.xml
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LogSearchDataRetrievalServiceTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintImplTest.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperImplTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/testing/DeadlockedThreadsTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartOnComponentLevelTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog221Test.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog210Test.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParserTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterDeployWithStartOnlyTest.java
* (edit) ambari-server/checkstyle.xml
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LogQueryResponseTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/MemberResourceProviderTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeSummaryResourceProviderTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/state/ConfigMergeHelperTest.java
> Clean up Ambari Server source code warnings
> -------------------------------------------
>
> Key: AMBARI-19149
> URL: https://issues.apache.org/jira/browse/AMBARI-19149
> Project: Ambari
> Issue Type: Task
> Components: ambari-server
> Reporter: Doroszlai, Attila
> Assignee: Doroszlai, Attila
> Fix For: 3.0.0
>
> Attachments: AMBARI-19149-1.patch, AMBARI-19149-3.patch,
> AMBARI-19149-4.patch, AMBARI-19149-5.patch, AMBARI-19149-6.patch,
> IDEA_Ambari_v1.xml
>
>
> Eclipse's default warnings generated for {{ambari-server}} number roughly
> over 3300. Out of these, at least half of them are:
> * Unused imports
> * Type safety due to forgotten {{<>}}
> * Missing Serialization IDs from anonymous {{HashMap}} implementations
> * Unused variables
> * {{Capture<T>}} in tests
> * {{switch}} fall-through and missing {{case statements}}: *only makes
> changes which won't affect existing functionality*
> This makes spotting actual problems, like missing {{case}} statements a
> nightmare. We need to go through and clean out as many of these warnings as
> possible.
> Note: With respect to the import cleanup, the IDE of choice should have the
> following import order setup. They should always be expanded and never use
> {{*}}.
> # {{java}}
> # {{javax}}
> # {{org}}
> # {{com}}
> # other
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
