[ https://issues.apache.org/jira/browse/ARROW-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221007#comment-16221007 ]
ASF GitHub Bot commented on ARROW-1689: --------------------------------------- wesm commented on issue #1237: ARROW-1689: [Python] Implement CategoricalBlock Index Zero-Copy URL: https://github.com/apache/arrow/pull/1237#issuecomment-339763811 Rebased and fixed flakes. The test case is failing, I will leave you to fix ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [Python] Categorical Indices Should Be Zero-Copy > ------------------------------------------------ > > Key: ARROW-1689 > URL: https://issues.apache.org/jira/browse/ARROW-1689 > Project: Apache Arrow > Issue Type: Improvement > Components: Python > Affects Versions: 0.7.1 > Reporter: Nick White > Assignee: Nick White > Labels: pull-request-available > Fix For: 0.8.0 > > > It seems like > [WriteIndices|https://github.com/apache/arrow/blob/0c8b861f93884f2868eb631d8fceee3a8b8905ec/cpp/src/arrow/python/arrow_to_pandas.cc#L955-L981] > could reuse some of the logic in > [ConvertValuesZeroCopy|https://github.com/apache/arrow/blob/0c8b861f93884f2868eb631d8fceee3a8b8905ec/cpp/src/arrow/python/arrow_to_pandas.cc#L1348-L1385] > to avoid copying the integer indices array? -- This message was sent by Atlassian JIRA (v6.4.14#64029)