[
https://issues.apache.org/jira/browse/ARROW-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217287#comment-16217287
]
ASF GitHub Bot commented on ARROW-1689:
---------------------------------------
wesm commented on a change in pull request #1233: ARROW-1689 Allow User To
Request No Data Copies
URL: https://github.com/apache/arrow/pull/1233#discussion_r146628354
##########
File path: cpp/src/arrow/python/arrow_to_pandas.cc
##########
@@ -1542,26 +1566,19 @@ class ArrowDeserializer {
}
Status Visit(const DictionaryType& type) {
+ if (options_.zero_copy_only) {
+ return Status::CopyRequired("DictionaryType needs copies");
+ }
+
auto block = std::make_shared<CategoricalBlock>(options_, nullptr,
col_->length());
RETURN_NOT_OK(block->Write(col_, 0, 0));
- auto dict_type = static_cast<const DictionaryType*>(col_->type().get());
-
PyAcquireGIL lock;
result_ = PyDict_New();
RETURN_IF_PYERROR();
- PyObject* dictionary;
-
- // Release GIL before calling ConvertArrayToPandas, will be reacquired
- // there if needed
- lock.release();
- RETURN_NOT_OK(
- ConvertArrayToPandas(options_, dict_type->dictionary(), nullptr,
&dictionary));
- lock.acquire();
-
Review comment:
Why is this deleted?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [Python] Categorical Indices Should Be Zero-Copy
> ------------------------------------------------
>
> Key: ARROW-1689
> URL: https://issues.apache.org/jira/browse/ARROW-1689
> Project: Apache Arrow
> Issue Type: Improvement
> Components: Python
> Affects Versions: 0.7.1
> Reporter: Nick White
> Labels: pull-request-available
>
> It seems like
> [WriteIndices|https://github.com/apache/arrow/blob/0c8b861f93884f2868eb631d8fceee3a8b8905ec/cpp/src/arrow/python/arrow_to_pandas.cc#L955-L981]
> could reuse some of the logic in
> [ConvertValuesZeroCopy|https://github.com/apache/arrow/blob/0c8b861f93884f2868eb631d8fceee3a8b8905ec/cpp/src/arrow/python/arrow_to_pandas.cc#L1348-L1385]
> to avoid copying the integer indices array?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
