[
https://issues.apache.org/jira/browse/ARROW-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16260026#comment-16260026
]
ASF GitHub Bot commented on ARROW-1710:
---------------------------------------
BryanCutler commented on a change in pull request #1341: [WIP] ARROW-1710:
[Java] Remove Non-Nullable Vectors
URL: https://github.com/apache/arrow/pull/1341#discussion_r152142514
##########
File path: java/vector/src/test/java/org/apache/arrow/vector/TestBitVector.java
##########
@@ -242,90 +230,81 @@ public void testReallocAfterVectorTransfer1() {
int valueCapacity = vector.getValueCapacity();
assertEquals(4096, valueCapacity);
- final BitVector.Mutator mutator = vector.getMutator();
- final BitVector.Accessor accessor = vector.getAccessor();
-
for (int i = 0; i < valueCapacity; i++) {
if ((i & 1) == 1) {
- mutator.setToOne(i);
+ vector.set(i, 1);
Review comment:
Slightly different API with the new BitVector
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [Java] Decide what to do with non-nullable vectors in new vector class
> hierarchy
> ---------------------------------------------------------------------------------
>
> Key: ARROW-1710
> URL: https://issues.apache.org/jira/browse/ARROW-1710
> Project: Apache Arrow
> Issue Type: Sub-task
> Components: Java - Vectors
> Reporter: Li Jin
> Assignee: Bryan Cutler
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
> So far the consensus seems to be remove all non-nullable vectors.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
