[
https://issues.apache.org/jira/browse/ARROW-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16260045#comment-16260045
]
ASF GitHub Bot commented on ARROW-1710:
---------------------------------------
BryanCutler commented on issue #1341: [WIP] ARROW-1710: [Java] Remove
Non-Nullable Vectors
URL: https://github.com/apache/arrow/pull/1341#issuecomment-345871911
@siddharthteotia @icexelloss please take a look when you have a chance.
There are still some things I was not sure of so I marked this as a WIP:
1) MapVector still has a non-nullable vector class in it's hierarchy. Maybe
I missed some previous discussion from the refactoring, but I couldn't just
remove the non-nullable class so I renamed them to be consistent with the other
vectors
2) Holders have both nullable and non-nullable, not sure if there is still a
use for that so I left it for now... maybe after ARROW-1833 we can fix this up
3) There are still references to NullableMapWriter/Reader, that got a little
messy trying to remove but I can try again later
cc @jacques-n @wesm
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [Java] Decide what to do with non-nullable vectors in new vector class
> hierarchy
> ---------------------------------------------------------------------------------
>
> Key: ARROW-1710
> URL: https://issues.apache.org/jira/browse/ARROW-1710
> Project: Apache Arrow
> Issue Type: Sub-task
> Components: Java - Vectors
> Reporter: Li Jin
> Assignee: Bryan Cutler
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
> So far the consensus seems to be remove all non-nullable vectors.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
