[
https://issues.apache.org/jira/browse/ARROW-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16262803#comment-16262803
]
ASF GitHub Bot commented on ARROW-1710:
---------------------------------------
icexelloss commented on issue #1341: [WIP] ARROW-1710: [Java] Remove
Non-Nullable Vectors
URL: https://github.com/apache/arrow/pull/1341#issuecomment-346386518
@BryanCutler High level looks good to me. Two major comments:
* Do we want to port the missing function (`getNullCount()` and
`setRangeToOne`) to the new bit vector?
* Can we remove `NonNullableMapVector` altogether? (git rid of the
`MapVector extends NonNullableMapVector` inherence and roll them into a single
class )
Happy thanksgiving!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [Java] Decide what to do with non-nullable vectors in new vector class
> hierarchy
> ---------------------------------------------------------------------------------
>
> Key: ARROW-1710
> URL: https://issues.apache.org/jira/browse/ARROW-1710
> Project: Apache Arrow
> Issue Type: Sub-task
> Components: Java - Vectors
> Reporter: Li Jin
> Assignee: Bryan Cutler
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
> So far the consensus seems to be remove all non-nullable vectors.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
