[
https://issues.apache.org/jira/browse/ARROW-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16262971#comment-16262971
]
ASF GitHub Bot commented on ARROW-1710:
---------------------------------------
BryanCutler commented on issue #1341: [WIP] ARROW-1710: [Java] Remove
Non-Nullable Vectors
URL: https://github.com/apache/arrow/pull/1341#issuecomment-346422375
> Do we want to port the missing function (getNullCount() and setRangeToOne)
to the new bit vector?
The new vector has `getNullCount()` just that it only counts nulls, maybe
the equivalent would be `getZeroCount()` but I'm not sure how useful that
really is. I think I saw there was also a `setRangeToOne` and I'm ok with
adding those.
> Can we remove NonNullableMapVector altogether? (git rid of the MapVector
extends NonNullableMapVector inherence and roll them into a single class )
I was thinking this is what we were going to do, maybe as a followup though,
so +1 for me. One thing I'm not sure of is ullability useful for this vector?
For example, Spark StructType doesn't have a nullable param, it's up to the
child type definitions. But maybe it's different in the Arrow sense, I'll have
to think about that..
Happy Thanksgiving to you all too! You guys work too hard, I don't want to
see any PRs coming through for a couple days :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [Java] Decide what to do with non-nullable vectors in new vector class
> hierarchy
> ---------------------------------------------------------------------------------
>
> Key: ARROW-1710
> URL: https://issues.apache.org/jira/browse/ARROW-1710
> Project: Apache Arrow
> Issue Type: Sub-task
> Components: Java - Vectors
> Reporter: Li Jin
> Assignee: Bryan Cutler
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
> So far the consensus seems to be remove all non-nullable vectors.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
