[ https://issues.apache.org/jira/browse/ARROW-1816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16269098#comment-16269098 ]
ASF GitHub Bot commented on ARROW-1816: --------------------------------------- icexelloss commented on a change in pull request #1330: ARROW-1816: [Java] Resolve new vector classes structure for timestamp, date and maybe interval URL: https://github.com/apache/arrow/pull/1330#discussion_r153566461 ########## File path: java/vector/src/main/java/org/apache/arrow/vector/NullableTimestampVector.java ########## @@ -179,6 +258,37 @@ public static long get(final ArrowBuf buffer, final int index) { return buffer.getLong(index * TYPE_WIDTH); } + public void get(int index, NullableTimestampHolder holder) { + if (isSet(index) == 0) { + holder.isSet = 0; + return; + } + holder.isSet = 1; + holder.value = valueBuffer.getLong(index * TYPE_WIDTH); + } + + @Override + public LocalDateTime getObject(int index) { + if (isSet(index) == 0) { + return null; + } else { + long millis = unit.getTimeUnit().toMillis(get(index)); Review comment: Good point. I encapsulated java TimeUnit detail. Also I ran a microbench toMilliis for 1B long values. Performance is the same. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [Java] Resolve new vector classes structure for timestamp, date and maybe > interval > ---------------------------------------------------------------------------------- > > Key: ARROW-1816 > URL: https://issues.apache.org/jira/browse/ARROW-1816 > Project: Apache Arrow > Issue Type: Sub-task > Reporter: Li Jin > Assignee: Li Jin > Labels: pull-request-available > Fix For: 0.8.0 > > > Personally I think having 8 vector classes for timestamps is not great. This > is discussed at some point during the PR: > https://github.com/apache/arrow/pull/1203#discussion_r145241388 -- This message was sent by Atlassian JIRA (v6.4.14#64029)