[ 
https://issues.apache.org/jira/browse/ARROW-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355703#comment-16355703
 ] 

ASF GitHub Bot commented on ARROW-2110:
---------------------------------------

xhochy commented on a change in pull request #1570: ARROW-2110: [Python] Only 
require pytest-runner on test commands
URL: https://github.com/apache/arrow/pull/1570#discussion_r166681861
 
 

 ##########
 File path: python/setup.py
 ##########
 @@ -428,6 +428,13 @@ def parse_version(root):
     else:
         return version
 
+
+# Only include pytest-runner in setup_requires if we're invoking tests
+if {'pytest', 'test', 'ptr'}.intersection(sys.argv):
 
 Review comment:
   PyTestRunner 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [Python] Only require pytest-runner on test commands
> ----------------------------------------------------
>
>                 Key: ARROW-2110
>                 URL: https://issues.apache.org/jira/browse/ARROW-2110
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: Python
>            Reporter: Uwe L. Korn
>            Assignee: Uwe L. Korn
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 0.9.0
>
>
> We only require it for tests, otherwise we should not depend on it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to