[
https://issues.apache.org/jira/browse/ARROW-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16356035#comment-16356035
]
ASF GitHub Bot commented on ARROW-2110:
---------------------------------------
wesm closed pull request #1570: ARROW-2110: [Python] Only require pytest-runner
on test commands
URL: https://github.com/apache/arrow/pull/1570
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/python/setup.py b/python/setup.py
index 726bb51f2..849d1203b 100644
--- a/python/setup.py
+++ b/python/setup.py
@@ -428,6 +428,13 @@ def parse_version(root):
else:
return version
+
+# Only include pytest-runner in setup_requires if we're invoking tests
+if {'pytest', 'test', 'ptr'}.intersection(sys.argv):
+ setup_requires = ['pytest-runner']
+else:
+ setup_requires = []
+
setup(
name="pyarrow",
packages=['pyarrow', 'pyarrow.tests'],
@@ -447,7 +454,7 @@ def parse_version(root):
]
},
use_scm_version={"root": "..", "relative_to": __file__, "parse":
parse_version},
- setup_requires=['setuptools_scm', 'cython >= 0.23', 'pytest-runner'],
+ setup_requires=['setuptools_scm', 'cython >= 0.23'] + setup_requires,
install_requires=install_requires,
tests_require=['pytest', 'pandas'],
description="Python library for Apache Arrow",
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [Python] Only require pytest-runner on test commands
> ----------------------------------------------------
>
> Key: ARROW-2110
> URL: https://issues.apache.org/jira/browse/ARROW-2110
> Project: Apache Arrow
> Issue Type: Improvement
> Components: Python
> Reporter: Uwe L. Korn
> Assignee: Uwe L. Korn
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.9.0
>
>
> We only require it for tests, otherwise we should not depend on it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
