zcsizmadia commented on PR #1666: URL: https://github.com/apache/avro/pull/1666#issuecomment-1105807947
The complexity of reviewing the SequenceEqual change is definetely higher than the actual problem the ticket scopes for. E.g. SequenceEqual is using the default comparer `EquityComparer<string>.Default`. Which is in your case is the `Ordinal` comparison code. IMO that knowledge is not trivial and can be easily missed. The unit tests should provide the baseline for the changes you make, unless the changes are trivial. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
