zcsizmadia commented on PR #1666: URL: https://github.com/apache/avro/pull/1666#issuecomment-1105814556
The other issue is changing the code behaviour of the Equals functions. It is standard practice to either throwing a exception if the argument is null or returning false. Some of the changes would return false instead of throwing the exception (which is the current implementation in some of those codes). Which might be ok, if we mark this PR as a major release PR, but in that case, the scope is definetely as it is described in the ticket. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
