marcosschroh commented on code in PR #2587:
URL: https://github.com/apache/avro/pull/2587#discussion_r1396095597
##########
lang/rust/avro/src/schema_compatibility.rs:
##########
@@ -96,10 +109,14 @@ impl Checker {
symbols: r_symbols, ..
}) = readers_schema
{
- return !w_symbols.iter().any(|e|
!r_symbols.contains(e));
+ if !w_symbols.iter().any(|e| !r_symbols.contains(e)) {
Review Comment:
Yes, all the symbols in the writer should be in the reader, I think you
suggestion makes sense and it is way better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
