woile commented on code in PR #2587:
URL: https://github.com/apache/avro/pull/2587#discussion_r1396906754
##########
lang/rust/avro/src/error.rs:
##########
@@ -478,6 +478,9 @@ pub enum Error {
#[error("Invalid Avro data! Cannot read codec type from value that is not
Value::Bytes.")]
BadCodecMetadata,
+
+ #[error("Schemas are not compatible. '{0}'")]
+ CompatibilityError(String),
Review Comment:
Yeah, that would also have to change. For the compatibility, you can just
use a `Result<(), CompatibilityError`. Looking at the code, it was just a
`bool` before. I would avoid from the get go tying it to `AvroResult`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
