TomBruns commented on code in PR #2751:
URL: https://github.com/apache/avro/pull/2751#discussion_r1499233098
##########
lang/csharp/src/apache/test/AvroGen/AvroGenSchemaTests.cs:
##########
@@ -619,7 +619,10 @@ public void NotSupportedSchema(string schema, Type
expectedException)
string schemaFileName = Path.Combine(outputDir,
$"{uniqueId}.avsc");
System.IO.File.WriteAllText(schemaFileName, schema);
- Assert.That(AvroGenTool.GenSchema(schemaFileName, outputDir,
new Dictionary<string, string>(), false), Is.EqualTo(1));
+ // We now support unknown logical types
+ //Assert.That(AvroGenTool.GenSchema(schemaFileName, outputDir,
new Dictionary<string, string>(), false), Is.EqualTo(1));
Review Comment:
removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
