a-kalashnikov commented on code in PR #2751: URL: https://github.com/apache/avro/pull/2751#discussion_r1554982498
########## lang/csharp/src/apache/main/Util/UnknownLogicalType.cs: ########## @@ -0,0 +1,163 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +using System; +using System.Collections.Generic; +using System.Text; + +namespace Avro.Util +{ + /// <summary> + /// Class UnknownLogicalType. + /// Implements the <see cref="Avro.Util.LogicalType" /> + /// </summary> + /// <seealso cref="Avro.Util.LogicalType" /> + public class UnknownLogicalType : LogicalType + { + /// <summary> + /// Gets the schema. + /// </summary> + /// <value>The schema.</value> + public LogicalSchema Schema { get; } + + /// <summary> + /// Initializes a new instance of the <see cref="UnknownLogicalType"/> class. + /// </summary> + /// <param name="schema">The schema.</param> + public UnknownLogicalType(LogicalSchema schema) : base(schema.LogicalTypeName) + { + this.Schema = schema; + } + + /// <summary> + /// Converts a logical value to an instance of its base type. + /// </summary> + /// <param name="logicalValue">The logical value to convert.</param> + /// <param name="schema">The schema that represents the target of the conversion.</param> + /// <returns>An object representing the encoded value of the base type.</returns> + public override object ConvertToBaseValue(object logicalValue, LogicalSchema schema) + { + switch (schema.Name) + { + case @"string": + return (System.String)logicalValue; + case @"boolean": + return (System.Boolean)logicalValue; + case @"int": + return (System.Int32)logicalValue; + case @"long": + return (System.Int64)logicalValue; + case @"float": + return (System.Single)logicalValue; + case @"double": + return (System.Double)logicalValue; + case @"bytes": + return (System.Byte[])logicalValue; + default: + return logicalValue; + } + } + + /// <summary> + /// Converts a base value to an instance of the logical type. + /// </summary> + /// <param name="baseValue">The base value to convert.</param> + /// <param name="schema">The schema that represents the target of the conversion.</param> + /// <returns>An object representing the encoded value of the logical type.</returns> + public override object ConvertToLogicalValue(object baseValue, LogicalSchema schema) + { + switch (schema.Name) + { + case @"string": + return (System.String)baseValue; + case @"boolean": + return (System.Boolean)baseValue; + case @"int": + return (System.Int32)baseValue; + case @"long": + return (System.Int64)baseValue; + case @"float": + return (System.Single)baseValue; + case @"double": + return (System.Double)baseValue; + case @"bytes": + return (System.Byte[])baseValue; + default: + return baseValue; + } + } + + /// <summary> + /// Retrieve the .NET type that is represented by the logical type implementation. + /// </summary> + /// <param name="nullible">A flag indicating whether it should be nullible.</param> + /// <returns>Type.</returns> + public override Type GetCSharpType(bool nullible) Review Comment: perhaps you meant null**A**ble instead of null**I**ble? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@avro.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
