thiru-mg commented on PR #3064: URL: https://github.com/apache/avro/pull/3064#issuecomment-2268116178
Looks good to me. There is a minor fidelity issue though: the JSON regenerated from the compiled schema loses the non-string type. That is, in the process of `JSON -> Schema -> JSON`, the input and output JSON may not be equivalent. However, `Schema -> JSON -> Schema` maintains fidelity. We can fix this by changing the type of `customAttributes`, but that will not be strictly compatible for the existing users. To address this, we can have a more general `customAttributes` inside the Schema object and expose it as `string->string map` for compatibility (as well as the more general map for generality). I'm fine with this fidelity issue for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
