jmd-z commented on PR #3064: URL: https://github.com/apache/avro/pull/3064#issuecomment-2269008639
Yes, it loses the distinction between a string value and a JSON fragment that would be up to the user to parse. I don't think a map of string->string would suffice as the fragment could be arbitrarily deep. The other approach, which appears to have been the intent of AVRO-3601, would be to make the string returned by customAttributes always a JSON fragment. This would change the current behavior as string values would have to contain quotes that aren't there today. Some of the existing tests are written this way, so instead of changing the current behavior I started with this approach to get some feedback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
