thiru-mg commented on code in PR #3332:
URL: https://github.com/apache/avro/pull/3332#discussion_r1982360930
##########
lang/c++/include/avro/Node.hh:
##########
@@ -170,7 +170,8 @@ public:
doAddCustomAttribute(customAttributes);
}
- virtual CustomAttributes getCustomAttributes() const = 0;
Review Comment:
Changing the return type an existing member function is a backward
incompatible change and my break existing client code. I suggest that we leave
the existing function as such and name the new function something like
`customAttributeCount()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
