wgtmac commented on code in PR #3332:
URL: https://github.com/apache/avro/pull/3332#discussion_r1993182012
##########
lang/c++/include/avro/NodeImpl.hh:
##########
@@ -164,15 +164,12 @@ protected:
customAttributes_.add(customAttributes);
}
- CustomAttributes getCustomAttributes() const override {
- CustomAttributes mergedCustomAttributes;
- for (size_t i = 0; i < customAttributes_.size(); i++) {
- const auto &customAttribute = customAttributes_.get(i);
- for (const auto &[key, value] : customAttribute.attributes()) {
- mergedCustomAttributes.addAttribute(key, value);
- }
- }
- return mergedCustomAttributes;
+ size_t customAttributes() const override {
+ return customAttributes_.size();
+ }
+
+ const CustomAttributes &customAttributesAt(size_t index) const override {
+ return customAttributes_.get(index);
Review Comment:
I can add bound check. Users are expected to call `customAttributes()`
before calling `customAttributesAt(i)` just like `namesAt` and `leaftAt`.
##########
lang/c++/include/avro/NodeImpl.hh:
##########
@@ -164,15 +164,12 @@ protected:
customAttributes_.add(customAttributes);
}
- CustomAttributes getCustomAttributes() const override {
- CustomAttributes mergedCustomAttributes;
- for (size_t i = 0; i < customAttributes_.size(); i++) {
- const auto &customAttribute = customAttributes_.get(i);
- for (const auto &[key, value] : customAttribute.attributes()) {
- mergedCustomAttributes.addAttribute(key, value);
- }
- }
- return mergedCustomAttributes;
+ size_t customAttributes() const override {
+ return customAttributes_.size();
+ }
+
+ const CustomAttributes &customAttributesAt(size_t index) const override {
+ return customAttributes_.get(index);
Review Comment:
I can add bound check. Users are expected to call `customAttributes()`
before calling `customAttributesAt(i)` just like `nameAt` and `leafAt`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
