wgtmac commented on code in PR #3435:
URL: https://github.com/apache/avro/pull/3435#discussion_r2253154779
##########
lang/c++/CMakeLists.txt:
##########
@@ -56,8 +56,25 @@ set(AVRO_VERSION
"${AVRO_VERSION_MAJOR}.${AVRO_VERSION_MINOR}.${AVRO_VERSION_PAT
project (Avro-cpp)
set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} ${CMAKE_SOURCE_DIR})
+# Try to respect BUILD_SHARED_LIBS if set. If not set, then fall back to the
original default of
+# both static and shared.
+if (DEFINED BUILD_SHARED_LIBS)
Review Comment:
`BUILD_SHARED_LIBS` has some drawbacks when the library is used as a
sub-project and it is not obvious to reason about the transitive behavior. So
I'm against adding `BUILD_SHARED_LIBS`. It sounds reasonable let users
explicitly toggle `AVRO_BUILD_STATIC` and `AVRO_BUILD_SHARED`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@avro.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
