here-abarany commented on code in PR #3435:
URL: https://github.com/apache/avro/pull/3435#discussion_r2254784504
##########
lang/c++/CMakeLists.txt:
##########
@@ -56,8 +56,25 @@ set(AVRO_VERSION
"${AVRO_VERSION_MAJOR}.${AVRO_VERSION_MINOR}.${AVRO_VERSION_PAT
project (Avro-cpp)
set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} ${CMAKE_SOURCE_DIR})
+# Try to respect BUILD_SHARED_LIBS if set. If not set, then fall back to the
original default of
+# both static and shared.
+if (DEFINED BUILD_SHARED_LIBS)
Review Comment:
Thanks for the reply, as that is your preference I have removed the logic
revolving around `BUILD_SHARED_LIBS`.
Any further thoughts on the other topic of `BUILD` vs `SKIP` (e.g.
`AVRO_BUILD_STATIC` vs. `AVRO_SKIP_STATIC`)? As stated I feel that `BUILD` is
more consistent with the other existing variables, but if there is a consensus
around preferring `SKIP` I am willing to change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
