wgtmac commented on code in PR #3475: URL: https://github.com/apache/avro/pull/3475#discussion_r2328915541
########## lang/c++/include/avro/Compiler.hh: ########## @@ -58,6 +60,9 @@ AVRO_DECL ValidSchema compileJsonSchemaFromString(const std::string &input); AVRO_DECL ValidSchema compileJsonSchemaFromFile(const char *filename); +AVRO_DECL ValidSchema compileJsonSchemaWithNamedReferences(std::istream &is, Review Comment: Just curious about the preference below for namedReferences: - `std::map` vs `std::unordered_map` - `avro::Name` vs `std::string` - `ValidSchema` vs `avro::NodePtr` ########## lang/c++/include/avro/Compiler.hh: ########## @@ -33,6 +34,7 @@ class AVRO_DECL InputStream; /// build up an avro parse tree as the avro spec is parsed. class AVRO_DECL ValidSchema; +class AVRO_DECL Name; Review Comment: nit: sort them alphabetically -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
