rayokota commented on code in PR #3475: URL: https://github.com/apache/avro/pull/3475#discussion_r2328979445
########## lang/c++/include/avro/Compiler.hh: ########## @@ -58,6 +60,9 @@ AVRO_DECL ValidSchema compileJsonSchemaFromString(const std::string &input); AVRO_DECL ValidSchema compileJsonSchemaFromFile(const char *filename); +AVRO_DECL ValidSchema compileJsonSchemaWithNamedReferences(std::istream &is, Review Comment: Typically the reference will be obtained by a method such as `compileJsonSchemaFromString`, which returns an instance of `ValidSchema` (as shown in `CompilerTests.cc`). `avro::Name` seems preferable since it prevents invalid namespaces and names. `std::map` is used for consistency with the underlying `SymbolTable`, which is also `std::map`. However, I don't have a strong preference in this case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
