martin-g commented on code in PR #3375:
URL: https://github.com/apache/avro/pull/3375#discussion_r2454300877


##########
lang/c/src/value-json.c:
##########
@@ -127,7 +126,7 @@ avro_value_to_json_t(const avro_value_t *value)
                                return NULL;
                        }
 
-                       json_t  *result = json_string_nocheck((const char *) 
encoded);
+                       json_t  *result = json_stringn_nocheck((const char *) 
encoded, encoded_size);

Review Comment:
   https://jansson.readthedocs.io/en/latest/apiref.html says that 
json_stringn_nocheck was added in jansson 2.7
   
   But we require 2.3+ at 
https://github.com/apache/avro/blob/a60a68f2c335aa1af943481b096c9941fd2bceda/lang/c/CMakeLists.txt#L182
   We need to bump it to 2.7+



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to