steven-aerts commented on code in PR #3375:
URL: https://github.com/apache/avro/pull/3375#discussion_r2459732424
##########
lang/c/src/value-json.c:
##########
Review Comment:
An empty byte array should be possible in avro.
When I tried making a test, I see it failing at other places making similar
mistakes.
Propose to create a separate patch with this test.
##########
lang/c/src/value-json.c:
##########
@@ -127,7 +126,7 @@ avro_value_to_json_t(const avro_value_t *value)
return NULL;
}
- json_t *result = json_string_nocheck((const char *)
encoded);
+ json_t *result = json_stringn_nocheck((const char *)
encoded, encoded_size);
Review Comment:
Nice catch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
